Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule improvements #1656

Merged
merged 4 commits into from
Oct 1, 2019
Merged

Schedule improvements #1656

merged 4 commits into from
Oct 1, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Oct 1, 2019 •
edited
Loading

Checklist:

@bjoernricks
Fail safely if ical data couldn't be parsed
9e8c5fe 
Don't crash the whole application if the ical data couldn't be parsed.
Instead log an error to the console and leave the schedule event
undefined.
@bjoernricks
Don't crash if schedule event is not available
d113815 
If the event is undefined, e.g. when the ical data has errors, don't
crash the schedule details and list pages. Instead just don't show the
start and next dates.
@codecov
Copy link

codecov bot commented Oct 1, 2019 •
edited
Loading

Codecov Report

Merging #1656 into gsa-8.0 will increase coverage by 0.01%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1656      +/-   ##
===========================================
+ Coverage    37.64%   37.65%   +0.01%     
===========================================
  Files          966      966              
  Lines        22103    22110       +7     
  Branches      6205     6210       +5     
===========================================
+ Hits          8320     8325       +5     
- Misses       12459    12460       +1     
- Partials      1324     1325       +1
Impacted Files Coverage Δ
gsa/src/web/pages/schedules/details.js 12.5% <0%> (-1.79%) ⬇️
gsa/src/web/pages/schedules/row.js 26.66% <0%> (-4.11%) ⬇️
gsa/src/gmp/models/schedule.js 100% <100%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6cd414...4b8023f. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review October 1, 2019 12:25
@bjoernricks bjoernricks requested a review from a team October 1, 2019 12:25
@bjoernricks bjoernricks merged commit a146554 into greenbone:gsa-8.0 Oct 1, 2019
@bjoernricks bjoernricks deleted the schedule-improvements branch October 1, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaterkamp swaterkamp swaterkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @swaterkamp