Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default report filter and sorting #1552

Merged
merged 4 commits into from
Aug 8, 2019
Merged

Default report filter and sorting #1552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de1d0e3
Update default filter for report details view
bjoernricks Aug 7, 2019
4dc655a
Sort results by severity by default
bjoernricks Aug 7, 2019
368f5fa
Include low severities by default
bjoernricks Aug 8, 2019
b1a7727
Add changelog entry
bjoernricks Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
[#1507](https://github.com/greenbone/gsa/pull/1507)

### Changed
- Update default filter for report details page [#1552](https://github.com/greenbone/gsa/pull/1552)
- Adjust HelpIcons to use GOS 5 manual [#1549](https://github.com/greenbone/gsa/pull/1549) [#1550](https://github.com/greenbone/gsa/pull/1550)
- Adjust clickable areas for Select and MultiSelect [#1545](https://github.com/greenbone/gsa/pull/1545)
- Redirect to main page when visiting the login page and the user is already
Expand Down
6 changes: 4 additions & 2 deletions gsa/src/web/pages/reports/detailspage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ import FilterDialog from './detailsfilterdialog';

const log = logger.getLogger('web.pages.report.detailspage');

const DEFAULT_FILTER = Filter.fromString('rows=100');
const DEFAULT_FILTER = Filter.fromString(
'levels=hml rows=100 min_qod=70 first=1 sort-reverse=severity',
);

const REPORT_FORMATS_FILTER = Filter.fromString('active=1 trust=1 rows=-1');

Expand All @@ -114,7 +116,7 @@ class ReportDetails extends React.Component {
showDownloadReportDialog: false,
sorting: {
results: {
sortField: 'created',
sortField: 'severity',
sortReverse: true,
},
apps: {
Expand Down