Default report filter and sorting #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaterkamp
reviewed
Aug 7, 2019
swaterkamp
requested changes
Aug 7, 2019
* Only show severity levels high and medium by default * Set min_qod to 70% (was already applied at the backend) * Set default sorting for report results to severity descending (should be applied for the export by default. still not used in gsa) * Set first to 1 (don't rely on backend)
For currently running scans this may be a bit cumbersome because the results may be resorted on every reload. Opening the result details may be difficult in this case. But nevertheless it seems to be the better solution to sort (nearly) all tabs by the same column and show the most important results at the top.
Add low level severities for default filter at report details page. Co-Authored-By: Steffen Waterkamp <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1552 +/- ##
========================================
Coverage 37.52% 37.52%
========================================
Files 965 965
Lines 21967 21967
Branches 6117 6117
========================================
Hits 8243 8243
Misses 12414 12414
Partials 1310 1310
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: