Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find python modules correctly #1483

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Find python modules correctly #1483

merged 1 commit into from
Jul 17, 2019

Conversation

hsntgm
Copy link
Contributor

@hsntgm hsntgm commented Jul 17, 2019

Fixes (missing: PY_POLIB) error on build time.

Actual behavior:

-- Could NOT find PY_polib (missing: PY_POLIB) 
   CMake Warning at gsa/po/CMakeLists.txt:108 (message):
   Could not build translation files: Python interpreter or polib Python
   module not found.

Expected behavior:

-- Found polib: /usr/lib64/python3.6/site-packages/polib.py (found version "1.1.0")

After fix:

-- Found polib: /usr/lib64/python3.6/site-packages/polib.py (found version "1.1.0")

I tried to push gsa-8.0 branch but messed it up, sorry :)
Old PR #1482

@hsntgm
Find python modules correctly.
68484af 
Fixes (missing: PY_POLIB) error on build time.
@bjoernricks bjoernricks mentioned this pull request Jul 17, 2019
Merged
1 task
bjoernricks
bjoernricks approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a backport with #1484

@bjoernricks bjoernricks merged commit 2956cc1 into greenbone:master Jul 17, 2019
@hsntgm hsntgm deleted the FindPythonModule branch July 17, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsntgm @bjoernricks