Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find python module correctly. #1482

Closed
wants to merge 305 commits into from
Closed

Find python module correctly. #1482

wants to merge 305 commits into from

Conversation

hsntgm
Copy link
Contributor

@hsntgm hsntgm commented Jul 17, 2019

Fixes (missing: PY_POLIB) error on build time.

Actual behavior:

-- Could NOT find PY_polib (missing: PY_POLIB) 
   CMake Warning at gsa/po/CMakeLists.txt:108 (message):
   Could not build translation files: Python interpreter or polib Python
   module not found.

Expected behavior:

-- Found polib: /usr/lib64/python3.6/site-packages/polib.py (found version "1.1.0")

After fix:

-- Found polib: /usr/lib64/python3.6/site-packages/polib.py (found version "1.1.0")

bjoernricks and others added 30 commits April 16, 2019 09:17
Remove copyright from gsad version output
Replace german "ist" with englisch "is" in a comment.
Consolidate new refs from NVTs
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #1482 into gsa-8.0 will decrease coverage by 0.46%.
The diff coverage is 31.01%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1482      +/-   ##
===========================================
- Coverage    37.43%   36.96%   -0.47%     
===========================================
  Files          963      996      +33     
  Lines        21812    22276     +464     
  Branches      6068     6115      +47     
===========================================
+ Hits          8165     8235      +70     
- Misses       12351    12726     +375     
- Partials      1296     1315      +19
Impacted Files Coverage Δ
gsa/src/web/components/menu/menu.js 31.81% <ø> (ø) ⬆️
gsa/src/gmp/parser.js 99.14% <ø> (ø) ⬆️
gsa/src/web/components/chart/schedule.js 21.05% <ø> (ø) ⬆️
gsa/src/web/components/chart/wordcloud.js 9.25% <ø> (ø) ⬆️
gsa/src/web/pages/scanconfigs/editdialog.js 8.77% <ø> (ø) ⬆️
gsa/src/web/pages/vulns/table.js 23.8% <ø> (ø) ⬆️
gsa/src/web/components/sortable/item.js 66.66% <ø> (ø) ⬆️
gsa/src/web/pages/alerts/method.js 2.18% <ø> (ø) ⬆️
gsa/src/web/pages/overrides/filterdialog.js 100% <ø> (ø) ⬆️
gsa/src/web/pages/ovaldefs/detailspage.js 19.14% <ø> (ø) ⬆️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d06f6...68484af. Read the comment docs.

@hsntgm hsntgm deleted the FindPythonModule branch July 17, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.