Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert content composer #1280

Merged
merged 6 commits into from
Apr 15, 2019
Merged

Alert content composer #1280

merged 6 commits into from
Apr 15, 2019

Commits on Apr 15, 2019

  1. Remove openContentComposerDialog binding 

    The method is already called from a bind function. Therefore it doesn't
need to be bind too.
    @bjoernricks
    bjoernricks committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    402a1c9 View commit details
    Browse the repository at this point in the history

  2. Always open content composer in alert dialog 

    Regardless of whether the displayed filter could be loaded always open
the content composer from the alert dialog.
    @bjoernricks
    bjoernricks committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    f36fdff View commit details
    Browse the repository at this point in the history

  3. Don't pass filter string to alert content composer 

    This allows to remove loading of the filter from alerts component
because we get the used filter from the already passed list of filters.
    @bjoernricks
    bjoernricks committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    141027e View commit details
    Browse the repository at this point in the history

  4. Store undefined for unset report result filter 

    Within GSA we should use undefined for unset values. At both ends
(dialog and api) we should convert undefined to the expected (maybe
different like in this case) value.
    @bjoernricks
    bjoernricks committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    3b72a21 View commit details
    Browse the repository at this point in the history

  5. Add changelog entry for alert report composer fix

    @bjoernricks
    bjoernricks committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    906ecc1 View commit details
    Browse the repository at this point in the history

  6. Don't require filter_id param for create_alert 

    Don't require a filter_id parameter to be passed to create_alert_gmp
function. The filter_id parameter is optional in GMP.
    @bjoernricks
    bjoernricks committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    1bf7558 View commit details
    Browse the repository at this point in the history