Alert content composer #1280
Merged
Alert content composer #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is already called from a bind function. Therefore it doesn't need to be bind too.
Regardless of whether the displayed filter could be loaded always open the content composer from the alert dialog.
This allows to remove loading of the filter from alerts component because we get the used filter from the already passed list of filters.
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1280 +/- ##
==========================================
+ Coverage 17.99% 18% +<.01%
==========================================
Files 952 952
Lines 27668 27659 -9
Branches 5979 5986 +7
==========================================
Hits 4980 4980
+ Misses 21282 21273 -9
Partials 1406 1406
Continue to review full report at Codecov.
|
Within GSA we should use undefined for unset values. At both ends (dialog and api) we should convert undefined to the expected (maybe different like in this case) value.
Don't require a filter_id parameter to be passed to create_alert_gmp function. The filter_id parameter is optional in GMP.
swaterkamp
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix opening the content composer from the alert dialog.
Fixes #1276
Checklist: