Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sourcefire PKCS12 password #1150

Merged
merged 8 commits into from
Jan 30, 2019

Conversation

swaterkamp
Copy link
Member

Added support for the PKCS12 password used by sourcefire. This includes adding a new credential type (pw) to gsa and gsad.

Checklist:

  • [ N/A ] Tests
  • [ X ] CHANGES Entry

@swaterkamp swaterkamp self-assigned this Jan 30, 2019
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #1150 into master will decrease coverage by <.01%.
The diff coverage is 6.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
- Coverage   15.28%   15.28%   -0.01%     
==========================================
  Files         843      843              
  Lines       27025    27046      +21     
  Branches     5755     5773      +18     
==========================================
+ Hits         4131     4133       +2     
- Misses      21494    21512      +18     
- Partials     1400     1401       +1
Impacted Files Coverage Δ
gsa/src/gmp/commands/alerts.js 7.89% <ø> (ø) ⬆️
gsa/src/web/pages/alerts/dialog.js 0% <ø> (ø) ⬆️
gsa/src/web/pages/credentials/dialog.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/alerts/sourcefiremethodpart.js 0% <0%> (ø) ⬆️
gsa/src/web/pages/alerts/component.js 0% <0%> (ø) ⬆️
gsa/src/gmp/models/credential.js 96.55% <66.66%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cb06e9...0f39894. Read the comment docs.

@swaterkamp swaterkamp added the work in progress This pull request should not be merged yet, more commits are expected label Jan 30, 2019
@swaterkamp swaterkamp removed the work in progress This pull request should not be merged yet, more commits are expected label Jan 30, 2019
@swaterkamp swaterkamp merged commit 44f8f7d into greenbone:master Jan 30, 2019
@swaterkamp swaterkamp deleted the SourcefirePassword branch February 20, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants