-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Sourcefire PKCS12 password #1150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is password only and used for sourcefire at the moment
Codecov Report
@@ Coverage Diff @@
## master #1150 +/- ##
==========================================
- Coverage 15.28% 15.28% -0.01%
==========================================
Files 843 843
Lines 27025 27046 +21
Branches 5755 5773 +18
==========================================
+ Hits 4131 4133 +2
- Misses 21494 21512 +18
- Partials 1400 1401 +1
Continue to review full report at Codecov.
|
swaterkamp
added
the
work in progress
This pull request should not be merged yet, more commits are expected
label
Jan 30, 2019
swaterkamp
force-pushed
the
SourcefirePassword
branch
from
January 30, 2019 14:37
c7f4609
to
b129632
Compare
swaterkamp
removed
the
work in progress
This pull request should not be merged yet, more commits are expected
label
Jan 30, 2019
timopollmeier
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the PKCS12 password used by sourcefire. This includes adding a new credential type (pw) to gsa and gsad.
Checklist: