Add option to not use a credential for PKCS12

greenbone · Jan 30, 2019 · b129632 · b129632
1 parent c674d96
commit b129632
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/gsa/src/web/pages/alerts/component.js b/gsa/src/web/pages/alerts/component.js
@@ -670,7 +670,7 @@ class AlertComponent extends React.Component {
           method_data_smb_file_path_type: undefined,
           method_data_verinice_server_report_format: select_verinice_report_id(
             report_formats),
-          method_data_pkcs12_credential: undefined,
+          method_data_pkcs12_credential: UNSET_VALUE,
           method_data_vfire_credential: undefined,
           method_data_vfire_base_url: undefined,
           method_data_vfire_call_description: undefined,

diff --git a/gsa/src/web/pages/alerts/sourcefiremethodpart.js b/gsa/src/web/pages/alerts/sourcefiremethodpart.js
@@ -37,7 +37,7 @@ import TextField from 'web/components/form/textfield';
 import FileField from 'web/components/form/filefield';
 
 import PropTypes from 'web/utils/proptypes';
-import {renderSelectItems} from 'web/utils/render';
+import {renderSelectItems, UNSET_VALUE} from 'web/utils/render';
 import withPrefix from 'web/utils/withPrefix';
 
 const SourcefireMethodPart = ({
@@ -81,7 +81,7 @@ const SourcefireMethodPart = ({
         <Divider>
           <Select
             name={prefix + 'pkcs12_credential'}
-            items={renderSelectItems(credentialOptions)}
+            items={renderSelectItems(credentialOptions, UNSET_VALUE)}
             value={pkcs12Credential}
             onChange={onCredentialChange}
           />

diff --git a/gsad/src/gsad_gmp.c b/gsad/src/gsad_gmp.c
@@ -7393,7 +7393,8 @@ append_alert_method_data (GString *xml, params_t *data, const char *method,
       {
         if (strcmp (name, "defense_center_ip") == 0
             || strcmp (name, "defense_center_port") == 0
-            || strcmp (name, "pkcs12_credential") == 0)
+            || (strcmp (name, "pkcs12_credential") == 0
+                && !str_equal (param->value, "0")))
           xml_string_append (xml,
                              "<data><name>%s</name>%s</data>",
                              name,