Fix gf shell not being able to access globals inside user defined functions. #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced in #414 where executing the following code in the GreatFET shell will fail with a
NameError: name 'time' is not defined error
:The fix has been tested on IPython versions
8.12.3
and8.26.0
.This PR also rolls back the version of IPython specified in the package dependencies to
"ipython~=8.12"
as this was the final version supported by Python 3.8 which is our minimum Python specification for the package.The current latest version IPython is
8.26.0
which requires Python>=3.10
.If GreatFET is installed on systems with Python
>=3.10
then the dependency spec~=8.12
will resolve as:>=8.12, ==8.*
.This ensures that the latest IPython will be installed on those systems.
Closes #435