Fix for the gf shell. Supports newer versions of IPython, v3.11+ #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter. Backwards compatible with v3.10 and earlier.
antoinevg
requested changes
May 3, 2023
| @@ -69,7 +68,12 @@ def main(): | |||
|
|
|||
|
|
|||
| # Create a new shell, and give it access to our created GreatFET object. | |||
| shell = TerminalInteractiveShell() | |||
| # Apr 18 2023 - Changed method for creating the shell, to support changes in IPython v8.11+ | |||
| # - ref. https://github.com/ipython/ipython/issues/13966 | |||
There was a problem hiding this comment.
You've already done a great job of documenting this in the PR itself so it doesn't need to be in the code as well.
There was a problem hiding this comment.
Updated the PR, Python comment removed. Please review and close this PR comment if it looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPython.terminal broke the greatfet shell such that any attempt to use it resulted in an exception ending in:
Exception 'NoneType' object has no attribute 'check_complete'This was traced to a change in IPython, version 8.11 and has broken other projects as well, refer to this issue in the IPython project: ipython/ipython#13966
This PR fixes the problem, as suggested in the issue report (linked above). It should be compatible with IPython v8.11 and later, and also backwards compatible for earlier versions of the library as well (as per the above issues last comment).
I tested the raw Python script (greatefet_shell.py) but have not managed to generate an install (.egg ?) using the README instructions. The .py file, when run directly, no longer creates an exception and the shell runs normally.
Please review for a merge or copy the simple change to your repo...
Alternatively, you could mention in the Docs that this issue can be fixed by rolling back IPython to an earlier version using pip3, (ver 8.10) although this is a sub-optimal alternative as all other, non greatfet, Python3 user scripts will now be forced to use the same older version of the library.