-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative to pnorman's building style #590
Conversation
Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss. Stops rendering supermarkets in a crazy pink to fix #520. Superceeds #550. Moves the rendering of train station areas to landcover. Fixes #327. Fixes #389 Removes outline differences based on a distinction that no one fully understands. Superceeds #533. Fixes #68
I toyed around with transparency, but couldn't really make it work. The problem is the colour looked like mud on some background. This looks better than what I had with transparency How do these look on the stronger backgrounds, like green, or on the more differing ones like |
So building in forest will have visible tree symbols on it? http://www.openstreetmap.org/?mlat=50.05799&mlon=19.87623#map=19/50.05799/19.87623 What about buildings in zoos? http://www.openstreetmap.org/?mlat=50.05453&mlon=19.85361#map=18/50.05453/19.85361 Or on sport areas? http://www.openstreetmap.org/?mlat=50.05677&mlon=19.94903#map=17/50.05677/19.94903 Or on landuse=commercial? http://www.openstreetmap.org/?mlat=50.05721&mlon=19.96088#map=17/50.05721/19.96088 Or in military areas? http://www.openstreetmap.org/?mlat=50.05491&mlon=19.97019#map=17/50.05491/19.97019 Or over water? http://www.openstreetmap.org/?mlat=50.04637&mlon=19.94767#map=18/50.04637/19.94767 |
@vholten If you want I can render a preview for it too, let me know when/if you feel its ready for that. |
Please, no transparency on buildings (and we should avoid translucent fills in general). I agree this PR makes the end result nicer, but similar effects can be achieved by having a non-transparent building fill and adjusting the over-colourful landuse colours instead. |
Any thoughts on different comp-ops, or do they have the same issues? |
Thank you all for your comments. I thought that adding transparency was worth a try, but since @gravitystorm has ruled it out, we should consider alternatives like changing the landuse colors. |
@vholten thank you for your contributions, and thank you all for the civil discussion! |
Another weird effect of transparency on buildings: link Question: why is the sports centre rendered gray? Answer: because the transparent purple/brown overlay of the buildings on top of the bright green of the sport complex landcover results in gray... |
I slowly start suspecting now that that was the reason for picking that ridiculous colour of green in the first place!? :) |
In #565, @pnorman presented a style that results in lighter buildings, which I think is an improvement. However, the lighter buildings were not visible enough on residential and industrial landuse. I have taken the liberty of making some changes to pnorman's style so that buildings look better on these types of landuse. (If there is no landuse, the rendering is the same as in #565.) In this way, there is no need to change landuse colors.
Comparison to pnorman's style
Left is pnorman's style from #565, right is the changed style
Buildings on industrial
Buildings on residential
Buildings without landuse (no difference)