Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render building=train_station #389

Closed
urilou opened this issue Mar 8, 2014 · 3 comments · Fixed by #1153
Closed

Render building=train_station #389

urilou opened this issue Mar 8, 2014 · 3 comments · Fixed by #1153

Comments

@urilou
Copy link

urilou commented Mar 8, 2014

Currently, building=train_station has been rendered in the same color as the building=yes.
I think should to render it highlight in the same way as building=station.

building=train_station have been used more than building=station, and it is highlighted in a transport map.

http://taginfo.openstreetmap.org/tags/?key=building&value=train_station
http://taginfo.openstreetmap.org/tags/?key=building&value=station

@javbw
Copy link

javbw commented Mar 10, 2014

This ties into #327 - The landuse and the station rendering needs to be sorted out. Maybe the building=train_station gets the strong red color, rather than the landuse?

@urilou
Copy link
Author

urilou commented Mar 12, 2014

Yes. I think building=train_station should be rendered in the same color(#d4aaaa) as the building=station.

building=train_station:
http://www.openstreetmap.org/#map=18/35.55859/139.55084
http://www.openstreetmap.org/way/265778999

building=station:
http://www.openstreetmap.org/#map=18/35.56880/139.55361
http://www.openstreetmap.org/way/265778998

@pnorman
Copy link
Collaborator

pnorman commented May 22, 2014

Yes. I think building=train_station should be rendered in the same color(#d4aaaa) as the building=station.

Unless we decide not to render the area around the station (see #327 for more info) rendering building=train_station the same as railway=station is a bad idea because they'll be the same colour, so the building will disappear inside the railway.

pnorman added a commit to pnorman/openstreetmap-carto that referenced this issue May 22, 2014
Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss.

Stops rendering supermarkets in a crazy pink to fix gravitystorm#520. Superceeds gravitystorm#550.

Moves the rendering of train station areas to landcover. Fixes gravitystorm#327. Fixes gravitystorm#389

Removes outline differences based on a distinction that no one fully understands. Superceeds gravitystorm#533. Fixes gravitystorm#68
pnorman added a commit to pnorman/openstreetmap-carto that referenced this issue May 25, 2014
Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss.

Stops rendering supermarkets in a crazy pink to fix gravitystorm#520. Superceeds gravitystorm#550.

Moves the rendering of train station areas to landcover. Fixes gravitystorm#327. Fixes gravitystorm#389

Removes outline differences based on a distinction that no one fully understands. Superceeds gravitystorm#533. Fixes gravitystorm#68
matthijsmelissen pushed a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Oct 1, 2014
Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss.

Stops rendering supermarkets in a crazy pink to fix gravitystorm#520. Superceeds gravitystorm#550.

Moves the rendering of train station areas to landcover. Fixes gravitystorm#327. Fixes gravitystorm#389

Removes outline differences based on a distinction that no one fully understands. Superceeds gravitystorm#533. Fixes gravitystorm#68
@matkoniecz matkoniecz self-assigned this Oct 14, 2014
pnorman added a commit that referenced this issue Oct 16, 2014
Refactor buildings code

Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss.

Stops rendering supermarkets in a crazy pink to fix #520. Superceeds #550.

Moves the rendering of train station areas to landcover. Fixes #327. Fixes #389

Removes outline differences based on a distinction that no one fully understands. Superceeds #533. Fixes #68

Rebased in 6b2a4de by math1985 <[email protected]>
@matkoniecz matkoniecz removed their assignment Oct 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants