Rewrite buildings #1153
Rewrite buildings #1153
Conversation
Refactor buildings code Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss. Stops rendering supermarkets in a crazy pink to fix gravitystorm#520. Superceeds gravitystorm#550. Moves the rendering of train station areas to landcover. Fixes gravitystorm#327. Fixes gravitystorm#389 Removes outline differences based on a distinction that no one fully understands. Superceeds gravitystorm#533. Fixes gravitystorm#68 Rebased in 6b2a4de by math1985 <[email protected]>
Rewrite of e7fe196
This adds the landcover labelling, which is significant Conflicts: landcover.mss project.mml project.yaml
…across all levels even the largest building in the world by footprint would be barely visible on z10 z11 so old building_major layer was not useful now major buildings (place_of_worship for start) are displayed specially across all zoom levels with visible buildings separate layer is necessary to ensure that building line of major building will be rendered on top of building line of touching building note that major buildings will be rendered on top of not major buildings, including major buildings with lower layer tag note that now aeroway terminal without building tag now will not be displayed
…gs_rewrite_new Conflicts: project.mml project.yaml
This should improve performance.
|
Not yet ready for merge. |
|
how about this for mss? #buildings[zoom >= 12],
#buildings-major[zoom >= 8][zoom < 12] {
polygon-fill: @building-fill;
polygon-clip: false;
[zoom >= 15] {
line-color: @building-line;
line-width: .75;
line-clip: false;
}
[aeroway = 'terminal'] {
polygon-fill: @building-aeroway-fill;
polygon-clip: false;
[zoom >= 15] {
line-width: .75;
line-clip: false;
line-color: @building-aeroway-line;
}
}
[amenity = 'place_of_worship'] {
polygon-fill: @building-major-fill;
polygon-clip: false;
[zoom >= 15] {
line-width: .75;
line-clip: false;
line-color: @building-major-line;
}
}
}You'll then need SQL that returns just important buildings at low zoom and all buildings at high zoom, and aeroway and amenity columns at all zooms. Do you think we need to render |
No, IMHO there is no reason to do this: http://wiki.openstreetmap.org/wiki/Tag:aeroway%3Dterminal mentions that building tag should be also present and defines it as "a building at an airport where (...)". Rendering PoW not on a building unlike buildings have even its own ticket. |
|
4880 This is consistent with the wiki, which defines |
|
No, the wiki specifies to 'Add building=yes [...] as appropriate'. |
|
I'm unassigning - @math1985 please reassign when ready for merging! |
That doesn't work, as pointed out by @mkoniecz in pnorman#5:
A separate attachment would work too, but would involve looping over all buildings twice. |
|
We received a lot of comments, both here and on talk. To summarize: It has been pointed out that the new colours might not work well with:
Some people propose adding a major/minor building distinction for e.g. garages. I don't think a three-tier system for buildings would work well graphically, so I don't really see this as a viable idea for the moment. There is a lot of debate about colouring places of worship darker. I counted three opinions in support and four opinions against. Among the collaborators there are also different opinions. I'm not sure what to do here. Some people say that the buildings might be a bit darker, especially on zoom 14-. Some people dislike the lighter colour in general, and mention that it does not look great against industrial / construction / residential background. Some people would prefer a more simple shade of gray, such as #d6d1c8. |
Colour proposed by vholten in gravitystorm#565 (comment)
On low zoom levels, buildings have no outline, so they need to be a bit darker in order to have the same visual effect.
|
I accepted the colour proposed by @vholten . I don't think this colour is really too close to living_street, and if it is, I'd propose changing the living_street colour. |
|
I agree buildings are too faint on the levels where they have no outline (14-). I made them a bit darken on these zoom levels. Thank you @imagico for the suggestion.
|
|
As far as I'm concerned, this is ready to be merged. I'm sure there will be some comments, but I don't think we can make everybody happy. Of courses, further changes are still possible. The only open issue is whether or not to render places of worship special. I think @gravitystorm can make the final call on that one. |
|
The new buildings look great. Great work collaborators!! |
|
|
|
Thanks @ all, this turned out pretty well! |
Major rewrite of building code. This will render the buildings much lighter.
See #565 for rationale.
Major thanks to @pnorman. Thanks to @mkoniecz for place of worship code.