Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runway and taxiway rendering rework #4607

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

pnorman
Copy link
Collaborator

@pnorman pnorman commented Jul 16, 2022

Changes proposed in this pull request:

zoom 15 YVR
image

zoom 17 YNJ
image

zoom 19 WA07
image

zoom 16 FRA
image

zoom 15 SIN
image

cc @jdhoek

pnorman added 3 commits July 16, 2022 00:10
At high zoom, runways stopped increasing in size. This made
them look excessively small compared to lower zooms. This extends
the scaling for them and taxiways, and adds a centerline to runways.
@pnorman pnorman requested a review from jeisenbe July 16, 2022 08:24
@imagico
Copy link
Collaborator

imagico commented Jul 16, 2022

Not looked at this in more detail but a quick remark on the line width progression. What you have right now is this:

For runways:

zoom line width max. ground width (in m at 0°) ratio to previous
12 4 153 -
13 6 115 0.75
14 12 115 1
15 18 86 0.75
16 24 57 0.67
17 40 48 0.83
18 56 33 0.7
19 72 21 0.64

For taxiways:

zoom line width max. ground width (in m at 0°) ratio to previous
13 2 38 -
14 4 38 1
15 6 29 0.75
16 8 19 0.67
17 11 13 0.69
18 16 10 0.73
19 72 7 0.69

As you can see in both cases you have a non-uniform progression, for runways more so than for taxiways.

Also note that the runway width will at low latitudes not drop to less than 21 meters - which is wider than most small informal airstrips you can find in many countries in rural areas. Like for example here:

https://www.openstreetmap.org/#map=12/3.9992/-73.2627

Such runways would with this change even at the highest zoom level be drawn wider than the actual width and potentially covering other features in the map.

The highly variable width runways can have from less than ten meters to 50 meters or more is the main reason why i had suggested in #1853 this would be a good candidate for introducing ground unit rendering based on tagged or heuristically estimated width. We don't have to do this but it would make it much easier to achieve a decent display of very small and very large runways likewise and at different latitudes.

@mboeringa
Copy link

mboeringa commented Jul 16, 2022

Such runways would with this change even at the highest zoom level be drawn wider than the actual width and potentially covering other features in the map.

I don't think that is a particular problem with runways. Even if the actual width of the prepared rural runway is narrow, obstacle clearance will usually be much bigger, and no significant overlap is expected in most cases.

@pnorman
Copy link
Collaborator Author

pnorman commented Jul 16, 2022

I've added some ideas from #4346

Also note that the runway width will at low latitudes not drop to less than 21 meters - which is wider than most small informal airstrips you can find in many countries in rural areas. Like for example here:

I didn't find any examples in your link where anything was mapped beside the runway, so nothing looks out of place there. I did look at another small local airport where there was overlap

zoom 18 27WA
image

I'm okay with there being overlap. The same happens with roads and other features, and it's likely to be less of an issue with runways because there are limited obstacles beside them.

The highly variable width runways can have from less than ten meters to 50 meters or more is the main reason why i had suggested in #1853 this would be a good candidate for introducing ground unit rendering based on tagged or heuristically estimated width. We don't have to do this but it would make it much easier to achieve a decent display of very small and very large runways likewise and at different latitudes.

I considered using width but decided against it, as I didn't want to add too much in one PR, and feel these changes stand alone.

@pnorman pnorman changed the title Aeroway layer Runway and taxiway rendering rework Jul 16, 2022
@imagico
Copy link
Collaborator

imagico commented Jul 16, 2022

I'm okay with there being overlap. The same happens with roads and other features

No, road width progression typically transits from larger than ground width to less than ground width at z17 or z18, in extreme cases at z19. And we depend on this being the case to reliably provide accurate geometry feedback on all the features we render at least on the highest zoom level. In rare cases, in particular for very narrow tertiary roads (see #3925) we do not accomplish that but this is something we should fix (see #3540) and not extend to other features.

I am not aware of any line features we routinely and deliberately draw wider in their ground width at z19.

I considered using width but decided against it, as I didn't want to add too much in one PR, and feel these changes stand alone.

In that case i suggest to limit the drawing width at z19 to less than the physical width in practically common cases. As i see it that would match our approach with other line features, in particular other road types.

The further design changes seem unclear in motivation to me. For example the chosen line color has less contrast towards the neutral gray fill colors we use for platforms/bridges and it harmonizes less well with the air transport symbol color. I am not aware of any problems with the current color. If you mean to free the current aeroway color for other purposes i could understand but if that makes sense would depend what purpose that might be. If there are other reasons i would like to understand them.

Like in #4346 i would suggest not to mix technical refactoring, design changes and feature additions all in one PR.

@pnorman
Copy link
Collaborator Author

pnorman commented Jul 17, 2022

The further design changes seem unclear in motivation to me. For example the chosen line color has less contrast towards the neutral gray fill colors we use for platforms/bridges and it harmonizes less well with the air transport symbol color. I am not aware of any problems with the current color.

There was a transcription error, I got the hue wrong. Fixed. Neither the current colour, incorrect change, nor corrected change bear any particular similarity to @airtransport: #8461C4 with different lightness, chroma, and hues.

@imagico
Copy link
Collaborator

imagico commented Jul 17, 2022

Ah, i see. The corrected color is only marginally different from the current one so that is fine with me.

For understanding the concept of harmonizing colors: Originally this style had a distinct violet color scheme for airports composed of the airport terminal building color, the apron color and the runway color. When choosing the air transport symbol and label color in #1033 fitting into that scheme was a major factor:

https://davidjohnstone.net/lch-lab-colour-gradient-picker#cc99ff,e9d1ff,bbbbcc,8461c4

Although we have meanwhile almost completely eliminated that color scheme by changing both the terminal building and apron colors (which introduced problems - see #3891 (comment) and also note the various issues we have with the 'major' building color) the choice and the reasoning behind it still echoes in the combination of runways and the air transport symbols, which practically in particular is visible for helipads. The hues of the air transport symbol color and the runway color are relatively close - close enough to form a harmonic unit. There were and are obviously other constraints.

https://davidjohnstone.net/lch-lab-colour-gradient-picker#bbbbbb,bbbbcc,babacb,8461c4,b1b9c7

The label design as shown would be a major departure from the current labeling paradigm in this style. I am not opposed to that in principle if it makes sense overall and we have agreement that this is a workable direction but i need to study this in more detail and i would also like to understand the reasoning behind the various aspects of this design choice.

One thing in particular to keep in mind here is that the display of runway/taxiway labels and of airport labels and symbols overlaps in zoom levels and having larger and stronger labels for runways than for the airport overall could be highly irritating.

@jdhoek
Copy link
Contributor

jdhoek commented Jul 17, 2022

I considered using width but decided against it, as I didn't want to add too much in one PR, and feel these changes stand alone.

Understandable. Is it something you would be willing to consider as a follow up? For runways (not for taxiways) it is a marked improvement in rendering due to the large area runways can have in real life.

Thank for picking the label design from my PR. It looks great. I would recommend taking one other feature from my PR though. This is a screenshot using this PR:

Screenshot from 2022-07-17 18-13-56

Compared with #4346 (different zoom-level):

110848275-34ff5080-82ae-11eb-9ce0-885758d505eb

This runway is mapped in a manner fairly common by now: it splits the runway proper from the displaced threshold and the stopway or blast pad (only runway 05/23, runway 09/27 doesn't have a displaced threshold). Stopways can be ignored here if you are limiting your PR to only the conceptual runway, but for displaced thresholds you might want to consider dropping the label like I did. Runways often are implemented like this in terms of scale and division:

>>>>>>>-------------------------------------------------------<<<<<<<

(>>> being the displaced thresholds)

Not labelling the displaced thresholds fixes runways having multiple unneeded labels, and limits the label to the main runway part. For runways this seems to work quite well.

Displaced runways are tagged like this:

aeroway=runway
runway=displaced_threshold
ref=05/23

@pnorman
Copy link
Collaborator Author

pnorman commented Jul 18, 2022

Not labelling the displaced thresholds fixes runways having multiple unneeded labels, and limits the label to the main runway part. For runways this seems to work quite well.

I agree with not labeling displaced thresholds. I'm not sure about using the on-runway marking for them, and would keep that for follow-up work.

The dashed line helps make it clearer what's going on in complex airports with lots of intersecting runways and taxiways. Without it, I find they tend to look like a mess of uninterrupted gray. JFK is one example of it.

@jdhoek
Copy link
Contributor

jdhoek commented Jul 18, 2022

I'm not sure about using the on-runway marking for them, and would keep that for follow-up work.

Those markings work a lot better when width is used to render the runway line as wide as it is in reality. Leaving out the markings is a good first step.

@pnorman pnorman mentioned this pull request Jul 27, 2022
@crjwalton
Copy link

CYPT has a paved runway that is 75 feet wide and a gravel runway that is 15 feet (4.6metres) wide. Painting both runways with the same line thickness is a bit deceiving.
https://www.openstreetmap.org/#map=16/41.7782/-82.6771

@Nic787
Copy link

Nic787 commented Apr 29, 2023

Any update on this project?

I think it should consider width used when tagging, but if it's not tagged, it should have a default width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runway, taxiway areas should not be rendered separate aeroways from rail/road query
6 participants