-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parking fill color is the same as living street fill color #3891
Comments
Also, |
Not as close but there are various other cases where unrelated features are rendered with very similar fill colors. Specifically apron and pedestrian colors are very close now - as well as #2353, #2905. I am generally not sure if there is agreement among maintainers that differences in fill colors should represent differences in meaning and colors should therefore not be overloaded for unrelated purposes. Similarity to other unrelated color played no role in discussion of most of these changes (#2292, #2934, #3444) and i am not sure if that is because it was being overlooked or if it was considered not to matter when the change was made. We also have cases with a deliberate choice to aggregate things fairly dissimilar in meaning into a common color (#3843 (comment)). From my perspective it comes all back to #2270. |
The apron vs pedestrian color similarity appears to have been overlooked in #3444 and the related issue #3385, from what I can see. There was discussion of using the It doesn't look like there was any discussion of the similarity between the new parking color and living-street-fill in #2934 or #2904 - these things are easy to miss if you don't look for them carefully. |
Could you show real problems with that? I don't remember a single time I had mistaken them. |
For some reason highway=living-street areas do not have a casing, unlike highway=pedestrian and highway=residential areas, otherwise they look identical to parking lots: z15 https://www.openstreetmap.org/#map=14/52.5183/13.1686 Only the parking icon makes it obvious at higher zoom levels (and these can be blocked by other icons, since they are low-priority) There are 1877 ways with This blocks adding a proper casing to |
|
These might be better examples:
Could all be mistaken for parking lots |
The only problem I see is Spandau areas example (the first one), so this effect looks very limited to me and I don't believe there are many disconnected areas like this. When areas are connected to the road system, it is totally clear to me that this is not a parking space. There is also interesting case here (near the last example), where parking is connected to a living street line and this is also something that leaves me no doubts: |
When areas are connected to the road system, it is totally clear to me
Since we are both very familiar with this style and in this case we
are thinking about the difference, we would probably be able to
distinguish the two features no matter what color was used for
`parking`.
But that is not an argument in favor of combining `living-street` and
`parking` under the same color.
We should also consider the new map user, who may never have heard of
a "living street" (they are not common outside of central Europe), or
even a highway area.
Also, when an area is incompletely mapped, for example the living
street area which is missing a connection to the linear road network,
this should also be visible.
I'm not claiming that this is a top-priority issue, but it is a minor
problem that should be fixed if possible.
|
Sorry if it sounded like rejection, I didn't mean it. Maybe you're right and somebody else could see this problem more clearly. I just provided my review and my conclusion is that it's much smaller issue than I expected. |
I think there is a problem with the closeness of colour, but living streets aren't common where I map so I'm not the right person to evaluate what changes make sense. |
Something similar happens with building passage. Combined with parking aisle, the service ways almost look disconnected. |
Yes, this shows that the tunnel fill color of white roads: openstreetmap-carto/style/roads.mss Line 65 in 445e553
is also fairly similar (slightly brighter) compared to both living street fill and parking fill: For comparison the AC-style: |
Expected behavior
Actual behavior
parking-fill
color,#eeeeee
is Lch (94,0,180)living-street-fill
color,#ededed
- also Lch (94,0,180)The text was updated successfully, but these errors were encountered: