Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landuse=brownfield looks fairly similar to buildings #2353

Open
imagico opened this issue Sep 19, 2016 · 13 comments
Open

landuse=brownfield looks fairly similar to buildings #2353

imagico opened this issue Sep 19, 2016 · 13 comments

Comments

@imagico
Copy link
Collaborator

imagico commented Sep 19, 2016

See for example here:

landuse=brownfield

http://overpass-turbo.eu/s/isQ

@imagico
Copy link
Collaborator Author

imagico commented Sep 19, 2016

Other lower zoom level example:

http://overpass-turbo.eu/s/isX

@kocio-pl
Copy link
Collaborator

I don't see the problem in the given example at this zoom level. I can see it for lower zoom levels, but I think it would be hard to find another color which is more distinct, yet not as dominant as before the change, which was a real problem for me. Lower zoom levels don't have to show all the differences, rather general shape, and current solution is good enough for me in that regard.

@pnorman
Copy link
Collaborator

pnorman commented Sep 20, 2016

👍 for it being an issue, but finding a suitable colour is always a pain.

@imagico
Copy link
Collaborator Author

imagico commented Sep 20, 2016

Yes, IMO #2292 did not improve things overall but this is a tough call. Map clarity is important and in general i much prefer not rendering something to rendering it in a misleading or confusing way.

Addressing this in an elegant way will require a look at the bigger picture, looking at both construction areas and roads (and other lifecycle related features) and looking at industrial landuses in the strict sense (i.e. landuse=quarry, landuse=landfill).

@kocio-pl
Copy link
Collaborator

I have the similar problem, which is much more visible for me (but still not important enough to open a separate ticket): landuse=commercial and landuse=retail are too similar. I can recognize them properly only if both such areas are close, otherwise I'm not sure in many cases.

@imagico
Copy link
Collaborator Author

imagico commented Nov 15, 2016

The difference is landuse=commercial/retail are very similar with many boundary cases even while buildings and landuse=brownfield are something completely different.

@kocio-pl
Copy link
Collaborator

Related to #1991.

@Tomasz-W
Copy link

I can admit that colour of brownfield is similar to buildings, but I think it isn't too similar and I don't see a big problem here. Note that buildings have outlines and brownfields haven't. There was no ideas how to solve it for a 2 years.
@kocio-pl What about closing it as "won't fix"?

@kocio-pl
Copy link
Collaborator

You're right probably - on the individual buildings level I can perfectly recognize them, at lower zoom levels I don't think it's important. Please reopen if further discussion is needed.

@jeisenbe
Copy link
Collaborator

I think this issue should be re-opened.

This problem is especially visible at z14 where buildings have no outlines and are darker:
@building-low-zoom: darken(@building-fill, 4%); is #cfc4b9 Lch(80,6,71) - this is rather close to @construction: #c9c4b4` Lch(80,10,109) - the lightness is identical, the chroma are almost the same, and the hue difference can be hard to see when the background is different. The delta is 6.5.

For example, buildings on industrial color background look very similar to adjacent construction areas:

@imagico has suggested the brownfield / construction color could be changed and this might fix the problem. For example, #c5bea6 would have a delta of 8.8, and it's lightness is 77, so this alone would make it less similar to low-zoom buildings.

Another option would be to reconsider the low-zoom buildings color. It is only used at this one zoom level, z14, where the outlines are not visible.

@Adamant36
Copy link
Contributor

You should make a test of @imagico's color. It might worth changing even if the low-zoom building color is changed.

@jeisenbe
Copy link
Collaborator

z14 Wilhemsburg:
https://www.openstreetmap.org/#map=14/53.5049/10.0179
z14-wilhelmsburg-construction-buildings

  • Hard to see the difference between industrial buildings and the landuse=construction or =brownfield areas.

Ochsenzoll https://www.openstreetmap.org/#map=14/53.6785/10.0097
z14-shalom-20percent

  • The large buildings on landuse=commercial to the southwest of the train station look similar to the landuse=construction to the southeast of the station

@imagico
Copy link
Collaborator Author

imagico commented Feb 27, 2020

Reopening because this has been closed essentially as subjective wontfix without consensus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants