-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
too strong color for leisure=pitch, leisure=track #1190
Comments
Definitely, but I would also suggest considering desaturating all landuse colours so that they work better with the new buildings colour. I know that this is not the easiest task to do, though. |
The landuse colours have been desaturated a lot already recently. Do you think all of them are too saturated, or some in particular? |
The colours that are used for "very large landuses where there are other things mapped" (e.g. farmland) are definite candidates. Farmland at F4EBDF works quite well for me, but other similar ones (large landuses that are often adjacent to farmland) would need to change too. (obviously ignore the other style changes there) |
I didn't know that. I really like the lighter building colour. I also think that built-up landuse like residential, industrial, retail, commercial could use a bit fine-tuning so that they work better with the new building colour. Overall, landuse colour should be paler (also farmland, forest, grass/meadow). The colour @SomeoneElseOSM suggested for farmland is not bad. But this needs more discussion, obviously. For now I would propose to adjust residential, industrial, retail, commercial and maybe construction and grass/meadow. Sorry for hijacking this issue, but I had a quick try: Please note that the building outline is 5% darker on the right than on the left. Some map previews: |
@nebulon42, I like your improvements. But maybe open a new issue for that? |
@nebulon42: Generally speaking your propositions are quite convincing for me - and thanks for such a a systematic colours study! Some remarks:
|
For pitches, we could add icons like the French rendering does. Perhaps than the colours don't need to be that distinct anymore. |
I like the french touch =} and agree that colours would not be that important then - the shape of pitch lines will be the key recognition feature. |
👍 to the pitch lines from the french rendering. Any chance this could be added soon? |
I thought we had an issue for that. Anyways, if you prepare a pull request then I can throw up some previews if needed to test the assortment of pitch combinations. |
The color is quite good, since even after modifications is still recognizable (construction color does not work so good on lower zooms). On sport centers (and other bigger campuses) even if they are weaker, there is no loss of visibility - z14: Before On plain residential area with schools (small campuses) they are not so dominant any more - z15: Before On z16 their visibility is back to normal on small campuses, despite being less strong - see also rare case of pitch on the residential area: After (lighten 5%, desaturate 5%) After (lighten 10%, desaturate 5%) Another quite common case, pitch on a grass - z17: Before |
It was noticeable before, now after building colour change it is quite bad. leisure=pitch, leisure=track should have muted/paler colour.
http://www.openstreetmap.org/#map=14/50.0735/19.9205
The text was updated successfully, but these errors were encountered: