Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

too strong color for leisure=pitch, leisure=track #1190

Closed
matkoniecz opened this issue Jan 4, 2015 · 11 comments
Closed

too strong color for leisure=pitch, leisure=track #1190

matkoniecz opened this issue Jan 4, 2015 · 11 comments

Comments

@matkoniecz
Copy link
Contributor

It was noticeable before, now after building colour change it is quite bad. leisure=pitch, leisure=track should have muted/paler colour.

http://www.openstreetmap.org/#map=14/50.0735/19.9205

selection_004

@matkoniecz matkoniecz changed the title too strong color for pitches too strong color for leisure=pitch, leisure=track Jan 4, 2015
@nebulon42
Copy link
Contributor

Definitely, but I would also suggest considering desaturating all landuse colours so that they work better with the new buildings colour. I know that this is not the easiest task to do, though.

@matthijsmelissen
Copy link
Collaborator

The landuse colours have been desaturated a lot already recently. Do you think all of them are too saturated, or some in particular?

@SomeoneElseOSM
Copy link
Contributor

The colours that are used for "very large landuses where there are other things mapped" (e.g. farmland) are definite candidates. Farmland at F4EBDF works quite well for me, but other similar ones (large landuses that are often adjacent to farmland) would need to change too.

After:
2671

Before:
2671

(obviously ignore the other style changes there)

@nebulon42
Copy link
Contributor

The landuse colours have been desaturated a lot already recently.

I didn't know that. I really like the lighter building colour. I also think that built-up landuse like residential, industrial, retail, commercial could use a bit fine-tuning so that they work better with the new building colour. Overall, landuse colour should be paler (also farmland, forest, grass/meadow). The colour @SomeoneElseOSM suggested for farmland is not bad.

But this needs more discussion, obviously. For now I would propose to adjust residential, industrial, retail, commercial and maybe construction and grass/meadow. Sorry for hijacking this issue, but I had a quick try:

landuse_color_small

Please note that the building outline is 5% darker on the right than on the left.

Some map previews:
http://www.openstreetmap.org/#map=17/48.21009/16.24593
bildschirmfoto vom 2015-01-04 17 50 19

http://www.openstreetmap.org/#map=16/48.1859/16.3825
bildschirmfoto vom 2015-01-04 17 52 15

http://www.openstreetmap.org/#map=16/48.1758/16.4014
bildschirmfoto vom 2015-01-04 17 53 49

@daganzdaanda
Copy link

@nebulon42, I like your improvements. But maybe open a new issue for that?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 5, 2015

@nebulon42: Generally speaking your propositions are quite convincing for me - and thanks for such a a systematic colours study! Some remarks:

  • retail is too close to commercial (but commercial for me is not well defined and close to retail)
  • the same for farmyard/farmland combo
  • landuse=military is missing here (with landuse=military+military=barracks case, which is even more problematic)
  • amenity=place_of_worship is not rendered now (which is not looking good to me) but amenity=place_of_worship+building=* is rendered as much darker than other buildings (which is good looking to me) - I wonder how your lighter version of amenity=place_of_worship plus current darker amenity=place_of_worship+building=* would look together (I guess that would be the best of both worlds).

@matthijsmelissen
Copy link
Collaborator

For pitches, we could add icons like the French rendering does. Perhaps than the colours don't need to be that distinct anymore.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 6, 2015

I like the french touch =} and agree that colours would not be that important then - the shape of pitch lines will be the key recognition feature.

@dkniffin
Copy link
Contributor

dkniffin commented Jun 4, 2015

👍 to the pitch lines from the french rendering. Any chance this could be added soon?

@pnorman
Copy link
Collaborator

pnorman commented Jun 17, 2015

👍 to the pitch lines from the french rendering. Any chance this could be added soon?

I thought we had an issue for that. Anyways, if you prepare a pull request then I can throw up some previews if needed to test the assortment of pitch combinations.

@kocio-pl
Copy link
Collaborator

The color is quite good, since even after modifications is still recognizable (construction color does not work so good on lower zooms).

On sport centers (and other bigger campuses) even if they are weaker, there is no loss of visibility - z14:

Before
rl5syqfs
After (lighten 5%, desaturate 5%)
ib atgcj
After (lighten 10%, desaturate 5%)
cadu4hhn

On plain residential area with schools (small campuses) they are not so dominant any more - z15:

Before
xbq0beaf
After (lighten 5%, desaturate 5%)
z vgz7gv
After (lighten 10%, desaturate 5%)
r8pvg6kc

On z16 their visibility is back to normal on small campuses, despite being less strong - see also rare case of pitch on the residential area:

Before
icbviglj

After (lighten 5%, desaturate 5%)
kvhfg7mq

After (lighten 10%, desaturate 5%)
cinlxdhd

Another quite common case, pitch on a grass - z17:

Before
sxk3imoq
After (lighten 5%, desaturate 5%)
ilz qryz
After (lighten 10%, desaturate 5%)
tdbjltf3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants