Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop rendering shop=yes [ready for review] #3718

Merged
merged 1 commit into from
Aug 22, 2019

Commits on May 11, 2019

  1. stop rendering shop=yes

    fixes gravitystorm#3697
    
    Originally only shop with their own icons were rendered.
    
    Later popular shop values were also rendered - as dots without icons. This was deliberate decision to not render tags with mistakes like shop=supermarkte
    
    Since gravitystorm#2415 all shop values except 'no', 'vacant', 'closed', 'disused', 'empty' are rendered.
    
    Given that any, even never used shop value is rendered and `shop=yes` is unreasonably popular it is desirable to encourage more specific shop tagging.
    
    Dropping `shop=yes` may encourage using some new shop values and in some cases people will mistakenly create new tags duplicating existing ones,
    but standard shop types are still encouraged by using icons.
    
    shop tag currently has long tail of unusual shop types (with most tagged correctly - for example `shop=maps`, some shop like this really exist),
    so data consumers need anyway some strategy for handling rare shop types.
    
    `shop=yes` is currenly reported as a tagging mistake by decent validators (for example JOSM and Osmose).
    
    Note that this is not deprecation of a tag but stopping to render a deprecated tag.
    This tag was never considered as a sufficient for tagging shop type
    matkoniecz committed May 11, 2019
    Configuration menu
    Copy the full SHA
    7216bb4 View commit details
    Browse the repository at this point in the history