Reverting lowzoom nobuilding test change #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good if someone made a test of the performance change with and without this line. Since low zoom tiles are refreshed quite rarely on OSMF servers, it's not primary concern, but it's still worth checking. It would be also good to have performance testing framework to make checking such things more common practice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial revert of #3539.
Changes proposed in this pull request:
landcover-low-zoomdata layer, since this might have performance implications (see this comment: https://github.com/gravitystorm/openstreetmap-carto/pull/3539/files#r244279150)Test rendering is positive (nothing is broken).