Landcover low zoom cleaning #3539
Conversation
| @@ -100,7 +100,6 @@ Layer: | |||
| WHERE (landuse IN ('forest', 'farmland', 'residential', 'commercial', 'retail', 'industrial', 'meadow', 'vineyard', 'orchard') | |||
| OR "natural" IN ('wood', 'wetland', 'mud', 'sand', 'scree', 'shingle', 'bare_rock', 'heath', 'grassland', 'scrub')) | |||
| AND way_area > 0.01*!pixel_width!::real*!pixel_height!::real | |||
| AND building IS NULL | |||
There was a problem hiding this comment.
Did you check performance implications of this?
There was a problem hiding this comment.
No, I just checked that nothing is broken. That's why I claim only code cleaning, not a performance boost.
There was a problem hiding this comment.
This change will probably have a performance regression. There is an important index on the polygon table (the "nobuilding" index) and the building is null part of the query is there in order to use this index and speed up queries.
It shouldn't be removed without careful testing.
There was a problem hiding this comment.
Yes, this change needs testing. If it hasn't been tested, we should revert this line.
There was a problem hiding this comment.
Could you make such test?
There was a problem hiding this comment.
Not in the near future. I think this line should be reverted as it's outside the scope of code cleanups to the landcover SQL.
There was a problem hiding this comment.
OK, PR is ready - #3622.
Related to #3534.
Resolves #1614.
Changes proposed in this pull request:
landcover-low-zoomdata layerThis should make the query marginally faster, but it's mostly code cleaning.