Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tertiary yellow and thinner after roads code refactoring #2228

Closed
wants to merge 1 commit into from

Conversation

kocio-pl
Copy link
Collaborator

Another try to resolve #1974.

Only tertiary colors and sizes are changed manually (other script-generated roads are not touched at all) using settings from from #2219.

Fast example (Warsaw, z16):
z0jdjzxu

@kocio-pl
Copy link
Collaborator Author

I don't know any details, but I've just found that test HD style is using tertiary with light yellow filling without changing the rest of a road colors - looks like it covers the whole world, so it can be useful for rough testing (probably only the filling color):

https://osm.rrze.fau.de/testhd.html

@matthijsmelissen
Copy link
Collaborator

I actually got used to the wide white tertiaries by now. I don't have a strong opinion whether or not to merge this. I see the more clearly distinguishable tertiaries as an advantage, but I also realize the new tertiary takes up again a part of the colour spectrum that we can't use for anything else.

@pnorman
Copy link
Collaborator

pnorman commented Jul 14, 2016

I'm finding there isn't enough difference between the two yellows. If I see the two side by side I can tell them apart, but if I look an area with a tertiary or secondary surrounded by residentials, I can't tell which it is.

If we change the colour I think this also requires changing the shields. I would much prefer it if the colour changes came via the scripts.

@imagico
Copy link
Collaborator

imagico commented Jul 14, 2016

I'm finding there isn't enough difference between the two yellows.

I am inclined to concur.

Of course there is no rule saying secondary and tertiary roads have to be distinguishable by color.

In the long term i'd think changing the admin boundary color and redistributing the road colors to reach more into purple (which right now is not possible because of the boundaries) would create sufficient room for a separate tertiary road color.

@kocio-pl
Copy link
Collaborator Author

I think general discussion for tertiary color belongs to #1974, so there is one place where we can swap ideas and argue which solution should we choose (if any).

I'd like to keep this PR as a technical ticket to implement the idea of changing only tertiary color.

@rrzefox
Copy link

rrzefox commented Jul 15, 2016

I don't know any details, but I've just found that test HD style is using tertiary with light yellow filling without changing the rest of a road colors - looks like it covers the whole world, so it can be useful for rough testing (probably only the filling color): https://osm.rrze.fau.de/testhd.html

Just updated that to v1.41.0 with this PR applied on top (was 1.39.0 with PR #2085 applied before - still is in places that haven't finished rerendering yet).

@matthijsmelissen
Copy link
Collaborator

Personally, I got used to the white tertiaries (as I said before). The current PR decreases the contrast between the roads and the background, while I'd rather see the contrast increased.

I'm therefore inclined to reject this PR. Any other opinions?

(Everybody who contributed on this, please don't take this personal, I know quite a lot of work has been put in this.)

@kocio-pl
Copy link
Collaborator Author

I put my work to test this idea as much as possible - and still I'm not sure, but that's not my decision, so nothing personal, indeed. =}

@mboeringa
Copy link

I'm therefore inclined to reject this PR. Any other opinions?

I don't agree. There's little harm implementing it, and it will help others. The final proposal by @kocio-pl is subtle enough to not be disturbing as a change.

@jdhoek
Copy link
Contributor

jdhoek commented Jul 26, 2016

Although I prefer a solution that maintains the colour gradient from motorway to tertiary using the road colours script, I feel that this is already a lot better than white tertiaries.

The problem I have with white tertiaries is that they are only distinguishable when there is not a lot happening on the map and the lines are straight. In a lot of cities though, width alone does not distinguish very well due to the amount of other detail on the map and the curving of the roads.

One particular example I have encountered is with frontage roads consisting of a tertiary highway flanked by residential highways. These become one broad white blur.

@wmyrda
Copy link

wmyrda commented Jul 26, 2016

I would vote yes, but I have two slight issues with it.
On z12 there is no gain from tertiary to appear light yellow as unclassified appears only as thin gray line. That is where I would rather have them stay white. On z13 onward I got used to seeing them white as one can better distinguish them in farmlands. Example here http://www.openstreetmap.org/#map=13/50.0974/22.3769 shows that yellow looks fine where only roads are drawn, but being surrounded by farmlands is whole different story.

@kocio-pl
Copy link
Collaborator Author

Well, now I think we should give up this idea. I also got used to white tertiary and I see two problems with making them yellow:

  1. We already have a lot of yellow objects - aside from the sand (which may be less of a problem) we use it for secondary roads, schools/hospitals/sport centers and parkings. Since these objects are quite common, it's a bit too much for my taste.
  2. I've just noticed that this shade of yellow is in practice identical to the shade of secondary in tunnel - the only difference is border, but one has to spot it. This is a corner case, since roads in tunnels are just a tiny fraction of all the roads, but I don't like this side effect:
    yr8zkgnq

@matthijsmelissen
Copy link
Collaborator

Well, now I think we should give up this idea.

I think both examples you give are instances of a wider problem: much of the colour space has been used already. Even if we manage to solve these two particular problems, we'll likely run into similar problems at different places.

I therefore agree we'll have to give up on this idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use different color for tertiary?
8 participants