Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Service Roads in their own color #3090

Closed
Adamant36 opened this issue Feb 26, 2018 · 18 comments
Closed

Render Service Roads in their own color #3090

Adamant36 opened this issue Feb 26, 2018 · 18 comments

Comments

@Adamant36
Copy link
Contributor

Any chance of having service roads render in their own color along with or instead of just being thinner than normal roads? Not that thinner roads is necessarily an issue, but changing them would make them easier to view and differentiate from normal roads at higher zoom levels. I'm not sure what color would work best. Something like what is being proposed in the issue about rendering road surface might be cool to.

@kocio-pl kocio-pl added the roads label Feb 26, 2018
@kocio-pl kocio-pl added this to the Bugs and improvements milestone Feb 26, 2018
@kocio-pl
Copy link
Collaborator

kocio-pl commented Feb 26, 2018

It's bigger than you think - roads make a system, so changing anything requires at least looking how it relates to others. Therefore I will close this issue now.

The main design principle for current roads rendering is making a color scale from very intense (red) to very pale (white), and the steps between colors are "well tempered" (we use even visual distance between them). One can test road color changes as described here: #110 (comment). I think without some practice with this code it doesn't really make sense to open issues for just one aspect.

BTW: I was testing light yellow for tertiary, but it didn't work - see #2228 - so it's even less probable for service roads.

@dieterdreist
Copy link

dieterdreist commented Feb 26, 2018 via email

@Adamant36
Copy link
Contributor Author

Adamant36 commented Feb 26, 2018

@kocio-pl I can understand that. I wasn't neccesarily talking about a complete redesign or anything that drastic though. If you don't mind me giving you an example, maybe you can come up with a solution for the problem that I'm not thinking off or maybe I'm imagining things and its not even a problem in the first place. This is from an Oil Refinery in the Bay Area.
Z16
z16
Z15
z15
Z14
z14
Z13
z13
On Z16 things look fine, but then the service roads almost become non-viewable on Z15. I'm not sure why, but it seems like they become a little easier to see on Z14 compared to Z15 for some reason. Even though it is zoomed out further. Then on Z13 the roads become gray and are way easier to distinguish. So would it be possible to also make them gray on Z14 and Z15 since they are to thin to see the white part at that point anyway?

As a side note to that, there is also an inconsistency between just normal service roads and parking aisles where parking aisles will disappear at Z15 and above, but normal service roads will not. Personally, I think having all service roads either turn gray at Z15 and above so are view-able would be cool. It seems to work good already at Z13 on normal service roads or they could all just disappear after Z15 like parking aisles do. Whatever option works best.

@dieterdreist
Copy link

dieterdreist commented Feb 26, 2018 via email

@imagico
Copy link
Collaborator

imagico commented Feb 26, 2018

IMHO, if the roads need to be visible in zoom13 or 14, they should likely not get the tag highway=service.

This is wrong on several different levels.

highway=service has a functional definition that bears no direct relationship to at what scale (let alone at what zoom level) it should ideally be shown in a map from a cartographic viewpoint.

Filtering which roads to show exclusively based on zoom level and tags is just a very crude approach to rendering which visibly fails in many cases. This is not a good reason to re-purpose highway=service into show_at=z15+ or something like that.

@polarbearing
Copy link
Contributor

inconsistency between just normal service roads and parking aisles where parking aisles will disappear...

Parking aisles and driveways are considered 'minor' service roads, so the different behaviour is intentional. Note that a parking area should have its access roads not being tagged parking_aisle.

@Adamant36
Copy link
Contributor Author

Adamant36 commented Feb 26, 2018

@polarbearing OK. It doesn't make that differentiation on the Wikipage. There's some pretty non minor driveways, especially shared ones, to that are more like residential roads in width etc, but still qualify as driveways in my opinion. So if that is the case, how is what qualifies as "minor" even defined? I guess it comes down to if you think the tag is meaning a more general service road or something like a frontage road.

@imagico Realistically, I would say your right. But functionally if every "road" was shown on the map at further zoomed out levels I would imagined the roads would overwhelm everything else. Especially considering how close together certain service roads like parking aisles are. Parking lots would just be a big clump of white. I also don't think people who are viewing a map at the regional scale care that much about where a parking aisle or driveway in some random shopping mall that they can barely see is. They probably only care about that type of information when they are zoomed into the neighborhood level. I can't imagine someone would be looking at the area in my example at the Z13 or Z14 level to find out that type of thing.

@dieterdreist
Copy link

dieterdreist commented Feb 26, 2018 via email

@dieterdreist
Copy link

dieterdreist commented Feb 26, 2018 via email

@SomeoneElseOSM
Copy link
Contributor

To return to the original question:

Any chance of having service roads render in their own color along with or instead of just being thinner than normal roads?

I'd certainly support that. I'm aware of what this map style is trying to do with road colours and I'm aware there's no easy answer (because colours used for different sorts of roads) will be effectively unavailable for other features), but I don't think the current colour choice "works" for me at all.

However, it;s worth noting that other map styles on osm.org can be used to see roads that are missing from the "standard" map. See for example https://www.openstreetmap.org/#map=15/53.1226/-1.3087 and https://www.openstreetmap.org/#map=15/53.1226/-1.3087&layers=C .

@kocio-pl
Copy link
Collaborator

Any chance of having service roads render in their own color along with or instead of just being thinner than normal roads?

I'd certainly support that.

The only chance I see (so this is just my opinion on the subject) is somebody making a road colors tuning, but it's a bigger task, which requires somebody willing to take care of this.

@polarbearing
Copy link
Contributor

how is what qualifies as "minor" even defined?

I have difficulties to understand your question, and do not know which wiki page you refer to.
To distinguish between minor and major service road rendering is a decision in this style here.

@Adamant36
Copy link
Contributor Author

I mean how is it decided what qualifies as a minor service road? on the wiki page for highway=service it does not split them into major and minor catagories. So is that something your saying OSM-Carto does? Or is it that you consider residential and other roads outside of the highway=service tag to also be "service roads", just not ones included on in the key? I guess service roads are usually considered as frontage roads, which kind of excludes some of it subkeys.

@dieterdreist
Copy link

dieterdreist commented Feb 27, 2018 via email

@Adamant36
Copy link
Contributor Author

Ah. Ok. Thanks for elaberation. Its still a side thing to my original complaint about service roads having viewing issues at certain zoom levels, but whatever. However you want to catagorize them or not the issue still exists and can probably be fixed.

@matthijsmelissen
Copy link
Collaborator

Which zoomlevels are the main problem according to you?

@Adamant36
Copy link
Contributor Author

I went into detail about it in my second message I think. The one with the pictures. The problem is on Z15 and Z14. On Z15 they are are really distorted and hard to see. It gets a little better on Z14 for some reason, but they are still not easy to make out. Then on Z13 they turn grey, which seems to solve the problem. So I was thinking they could turn grey on Z14 and Z15 or just disappear, like parking aisles do already at those zoom levels. Things went off track really quickly though and it never went anywhere.

@matthijsmelissen
Copy link
Collaborator

Yes, I see what you mean. As I'm quite busy, could you perhaps prepare a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants