Reformat road SQL #2168
Reformat road SQL #2168
Conversation
| @@ -992,7 +1011,7 @@ Layer: | |||
| foot, | |||
| bicycle, | |||
| tracktype, | |||
| 'null', | |||
| 'null' AS surface, -- Should be a SQL NULL? | |||
There was a problem hiding this comment.
I am not understanding this comment. Is it question about why the NULL is here?
There was a problem hiding this comment.
null is here as it makes little sense to query surface for railways.
on the other hand querying some other tags like tracktype, bicycle, foot for railways is also rather pointless so there is no good reason to do the same for surface.
Also, for aeroway querying surface is not completely pointless.
Overall replacing this null by querying surface may be a good idea.
There was a problem hiding this comment.
sent from a phone
Il giorno 15 giu 2016, alle ore 12:45, Mateusz Konieczny [email protected] ha scritto:
on the other hand querying some other tags like tracktype, bicycle, foot for railways is also rather pointless so there is no good reason to do the same for surface.
maybe this is (or was) to cater for some railway=abandoned that now are tracks, or footways or cycleways?
There was a problem hiding this comment.
There has to be a column as part of that query as it's part of a JOIN. The question isn't why there's a colum, but if it should be 'null'::text or NULL::text
Pulled from #2058