Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start merging road areas into roads layers #2058

Closed
wants to merge 2 commits into from

Conversation

pnorman
Copy link
Collaborator

@pnorman pnorman commented Feb 23, 2016

cross-ref #2046

This is how far I got before I had to travel, but should reviewable on its own.

@matthijsmelissen
Copy link
Collaborator

Are the reordering in the .mss necessary and the whitespace changes necessary? If not, could you propose these as a separate PR?

@pnorman
Copy link
Collaborator Author

pnorman commented Feb 24, 2016

Are the reordering in the .mss necessary and the whitespace changes necessary? If not, could you propose these as a separate PR?

They're needed since they belonged to the roads area layer, which is now gone. The only whitespace change is because they end up nested differently within the roads fill layer.

I think there's an opportunity to refactor that part of the MSS and simplify it, but haven't looked at it in enough detail yet.

@matthijsmelissen
Copy link
Collaborator

Something is still wrong with this PR, areas now also render as linear roads. This causes them to be rendered too big (as the outline is rendered too).

I didn't know it was possible to just leave out the geometry field, by the way.

@matkoniecz
Copy link
Contributor

Something is still wrong with this PR, areas now also render as linear roads. This causes them to be rendered too big (as the outline is rendered too).

What results in following problems: https://cloud.githubusercontent.com/assets/899988/15871159/70ebd0a2-2cf3-11e6-9256-bbe85db6c0ef.png

@pnorman
Copy link
Collaborator Author

pnorman commented Jun 15, 2016

Closing as don't know when I'll have time to resume work on this.

@pnorman pnorman closed this Jun 15, 2016
@pnorman pnorman mentioned this pull request Jun 15, 2016
@pnorman pnorman deleted the road_areas branch April 7, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants