Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made motorways more prominent. Fixes issue #1946 #1973

Closed
wants to merge 1 commit into from

Conversation

KenBW2
Copy link

@KenBW2 KenBW2 commented Nov 12, 2015

As per issue #1946, motorways blend in with trunk roads far too much, which doesn't reflect their importance, and difference with other road types. This commit makes them more prominent, while still maintaining the principle of similar-hue-for-similar-way-types to ensure this remains an all-purpose map style.

Example with new motorway colours overlayed on existing map:

newmotorway

@pnorman
Copy link
Collaborator

pnorman commented Nov 13, 2015

These changes will be lost when rerunning generate_road_colours

@KenBW2
Copy link
Author

KenBW2 commented Nov 13, 2015

I've obviously misunderstood then. Where are the values set if not in the .mss files?

@pnorman
Copy link
Collaborator

pnorman commented Nov 13, 2015

The values are generated by the script.

@matkoniecz
Copy link
Contributor

Maybe motorways may be stronger - but on example the difference seems to be too big.

This motorway is more visible than all other elements together, including city label.

@jojo4u
Copy link

jojo4u commented Nov 13, 2015

This is too strong, the jump from trunk to motorway is not justified.

@matthijsmelissen
Copy link
Collaborator

Maybe motorways may be stronger - but on example the difference seems to be too big.

+1

@SomeoneElseOSM
Copy link
Contributor

Re "generate_road_colours" - is there anything written down about that anywhere? Or even just a link to where it was created and included in the process? Having that more prominent might have prevented someone wasting their time solving a problem in a way that "doesn't fit" with the current approach.

@matthijsmelissen
Copy link
Collaborator

The consensus is that this proposed change is not an improvement, so I'll reject this pull request. Thank you for the effort though @KenBW2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants