Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up #roads-low-zoom layer #170

Merged
merged 2 commits into from
Sep 18, 2013
Merged

Clean up #roads-low-zoom layer #170

merged 2 commits into from
Sep 18, 2013

Conversation

matthijsmelissen
Copy link
Collaborator

Changes:

  • Move preserved railways and monorails from low-zoom layer #roads-low-zoom to high-zoom layer #roads-fill
  • Remove funicular selector that never gets hit

This pull request solves the following problem:

  • #roads-low-zoom contains also high-zoom objects

This pull request changes the rendering as follows:

  • The purpose of this pull request is improving the readability of the code. However, this pull request also has minor effects on rendering order. In particular, monorails and preserved railways are now (just like other railways) displayed below aerialways, ferry routes, and the fill of turning circles, instead of above them. Depending on the z-order, monorails and preserved railways might now also be displayed below other types of roads and railways, instead of above them.

@matthijsmelissen
Correct names of layers that have unclear names for historical reaons.
b6dee06 
- Rename #roads to #roads-low-zoom
- Rename #minor-roads-casing to #roads-casing
- Rename #minor-roads-fill to #roads-fill
@matthijsmelissen
Clean up low-zoom layer
47d335d 
- Move preserved railways and monorails from low-zoom layer #roads-low-zoom
- Remove funicular rule that never gets hit
@matthijsmelissen matthijsmelissen mentioned this pull request Sep 17, 2013
Closed
@matthijsmelissen
Copy link
Collaborator Author

This completes step 1 of #162.

@gravitystorm gravitystorm merged commit 47d335d into gravitystorm:master Sep 18, 2013
@matthijsmelissen matthijsmelissen deleted the roadsv1.1 branch December 2, 2013 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthijsmelissen @gravitystorm