Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up low-zoom layer #166

Closed

Conversation

matthijsmelissen
Copy link
Collaborator

Changes:

  • Move preserved railways and monorails from low-zoom layer #roads-low-zoom to high-zoom layer #roads-fill
  • Remove funicular selector that never gets hit

This pull request solves the following problem:

  • #roads-low-zoom contains also high-zoom objects

This pull request changes the rendering as follows:

  • The purpose of this pull request is improving the readability of the code. However, this pull request also has minor effects on rendering order. In particular, monorails and preserved railways are now (just like other railways) displayed below aerialways, ferry routes, and the fill of turning circles, instead of above them. Depending on the z-order, monorails and preserved railways might now also be displayed below other types of roads and railways, instead of above them.

@matthijsmelissen
Copy link
Collaborator Author

This completes step 1 of #162.

- Rename #roads to #roads-low-zoom
- Rename #minor-roads-casing to #roads-casing
- Rename #minor-roads-fill to #roads-fill
- Move preserved railways and monorails from low-zoom layer #roads-low-zoom
- Remove funicular rule that never gets hit
@matthijsmelissen
Copy link
Collaborator Author

Superseded by #170, which has less spurious commits.

@gravitystorm
Copy link
Owner

I'm assuming this should be closed, please reopen if I'm wrong.

@matthijsmelissen
Copy link
Collaborator Author

Yes, thanks.

@matthijsmelissen matthijsmelissen deleted the roadsv1.1 branch December 2, 2013 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants