Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NET-244): use static http server port on windows #471

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

Aceix
Copy link
Contributor

@Aceix Aceix commented Jun 21, 2023

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

@Aceix Aceix marked this pull request as ready for review June 21, 2023 11:19
gui/main.go Outdated Show resolved Hide resolved
gui/main.go Outdated Show resolved Hide resolved
@Aceix Aceix requested a review from mattkasun June 21, 2023 13:00
functions/httpserver.go Outdated Show resolved Hide resolved
@Aceix Aceix requested a review from abhishek9686 June 23, 2023 10:56
@afeiszli afeiszli merged commit 3ef4648 into develop Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants