fix(NET-244): use static http server port on windows (#471)

* fix(NET-244): use static http server port on windows

* fix(NET-244): remove unnecessary named import

* fix(NET-244): rename vars to follow convention

functions/httpserver.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"log"
 	"net/http"
+	"runtime"
 	"strings"
 	"sync"
 
@@ -22,19 +23,26 @@ type Network struct {
 	Server config.Server
 }
 
+const DefaultHttpServerPort = "18095"
+const DefaultHttpServerAddr = "127.0.0.1"
+
 func HttpServer(ctx context.Context, wg *sync.WaitGroup) {
 	defer wg.Done()
 	if config.Netclient().DisableGUIServer {
 		return
 	}
-	port, err := ncutils.GetFreeTCPPort()
-	if err != nil {
-		logger.Log(0, "failed to get free port", err.Error())
-		logger.Log(0, "unable to start http server", "exiting")
-		logger.Log(0, "netclient-gui will not be available")
-		return
+	port := DefaultHttpServerPort
+	if runtime.GOOS != "windows" {
+		p, err := ncutils.GetFreeTCPPort()
+		if err != nil {
+			logger.Log(0, "failed to get free port", err.Error())
+			logger.Log(0, "unable to start http server", "exiting")
+			logger.Log(0, "netclient-gui will not be available")
+			return
+		}
+		port = p
 	}
-	config.SetGUI("127.0.0.1", port)
+	config.SetGUI(DefaultHttpServerAddr, port)
 	config.WriteGUIConfig()
 
 	router := SetupRouter()

gui/main.go

@@ -3,8 +3,10 @@ package main
 import (
 	"embed"
 	"log"
+	"runtime"
 
 	"github.com/gravitl/netclient/config"
+	"github.com/gravitl/netclient/functions"
 	"github.com/gravitl/netmaker/logger"
 	"github.com/wailsapp/wails/v2"
 	"github.com/wailsapp/wails/v2/pkg/options"
@@ -22,15 +24,17 @@ var appIcon = GetFileAsBytes("./appicon.png")
 
 var version = "v0.20.3"
 
-var url = "http://127.0.0.1:8090"
+var url = "http://" + functions.DefaultHttpServerAddr + ":" + functions.DefaultHttpServerPort
 
 func main() {
 	log.Println("staring netclient gui version: ", version) // temp.. version should be displayed in about dialog
-	http, err := config.ReadGUIConfig()
-	if err != nil {
-		logger.FatalLog("error reading gui config", err.Error())
+	if runtime.GOOS != "windows" {
+		http, err := config.ReadGUIConfig()
+		if err != nil {
+			logger.FatalLog("error reading gui config", err.Error())
+		}
+		url = "http://" + http.Address + ":" + http.Port
 	}
-	url = "http://" + http.Address + ":" + http.Port
 	// Create an instance of the guiApp structure
 	guiApp := NewApp()
 	guiApp.GoGetNetclientConfig()
@@ -68,7 +72,7 @@ func main() {
 	}
 
 	// Create application with options
-	err = wails.Run(appOptions)
+	err := wails.Run(appOptions)
 
 	if err != nil {
 		println("Error:", err.Error())