Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-282: removed proxy dependency on peer updates, only use proxy for turn operations #453

Merged
merged 24 commits into from
Jun 12, 2023
Merged

NET-282: removed proxy dependency on peer updates, only use proxy for turn operations #453

merged 24 commits into from
Jun 12, 2023

Conversation

abhishek9686
Copy link
Member

@abhishek9686 abhishek9686 commented Jun 9, 2023 •
edited by theguy951357
Loading

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

gravitl/netmaker#2388

Provide testing steps

  • Make clients to use turn, and test the connection
  • check if host is getting assigned public endpoint,should be reflected on UI

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

abhishek9686 and others added 20 commits June 1, 2023 15:28
@abhishek9686 abhishek9686 mentioned this pull request Jun 9, 2023
Merged
8 tasks
TobiaszCudnik
TobiaszCudnik approved these changes Jun 9, 2023
View reviewed changes
nmproxy/proxy/proxy_helper.go Show resolved Hide resolved
theguy951357
theguy951357 approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr passes

@abhishek9686 abhishek9686 merged commit 684c9c6 into refactor_peer_updates Jun 12, 2023
abhishek9686 added a commit that referenced this pull request Jul 26, 2023
@abhishek9686
NET-447: Proxy Removal (#515)
2ff3070 
* NET-10: Refactor Peer update Phase-1 (#407)

* singleton peer update mq handler

* process adding and removing single peer

* avoid restarting daemon on join to network host update

* handle peer list on singleton update

* support multiple peer removal

* use map for peer data

* init peer map

* don't retrun if wg file update fails

* add debug comment

* add debug comment

* add func comments

* add comment

* rm ununsed funcs

* NET-193: Refactor Peer Updates - Firewall Manager (#418)

* singleton peer update mq handler

* process adding and removing single peer

* avoid restarting daemon on join to network host update

* handle peer list on singleton update

* support multiple peer removal

* use map for peer data

* init peer map

* don't retrun if wg file update fails

* add debug comment

* add debug comment

* add func comments

* add comment

* rm ununsed funcs

* detach firewall from proxy and peer updates

* rm unused funcs

* close firewall in daemon shutdown

* initialize firewall on start of the daemon

* rm config related to fw from proxy

* add netmaker forward rule on firewall init

* return if firewall is not initialized

* sync firewall rule on pull

* rm commented code

* update netclient dockerfile to support ip6tables

* rename pkg to firewall

* remove relay implementation from proxy

* remove relay implementation from proxy (#425)

* remove unwanted relay check

* remove relay config

* remove proxy server components

* remove proxy utilities

* rm unused proxy config

* remove multi-server support for turn

* remove NAT Auto Switch

* remove multi-server support for turn

* update go mod

* remove servers loop

* fix issues with merge conflicts

* NET-282: removed proxy-to-proxy comms, removed proxy udp server (#447)

* remove relay implementation from proxy

* remove unwanted relay check

* remove relay config

* remove proxy server components

* remove proxy utilities

* rm unused proxy config

* remove multi-server support for turn

* remove NAT Auto Switch

* remove multi-server support for turn

* update go mod

* remove servers loop

* fix issues with merge conflicts

* Net 282 proxy (#450)

* remove proxy manager

* use nat info for public IP

* remove server param

* rm ununsed proxy config

* statr proxy only if client is registered to a server

* rm unused func

* update go mod, remove usage of proxy listen port

* remove server map, network settings

* use tcp pinger to determine peer connection status and latency

* remove nat info usage

* nil pointer error fix,remove unused fields

* use icmp pinger for extclient

* NET-282: removed proxy dependency on peer updates, only use proxy for turn operations (#453)

* remove relay implementation from proxy

* remove unwanted relay check

* remove relay config

* remove proxy server components

* remove proxy utilities

* rm unused proxy config

* remove multi-server support for turn

* remove NAT Auto Switch

* remove multi-server support for turn

* update go mod

* remove servers loop

* fix issues with merge conflicts

* Net 282 proxy (#450)

* remove proxy manager

* use nat info for public IP

* remove server param

* rm ununsed proxy config

* statr proxy only if client is registered to a server

* rm unused func

* update go mod, remove usage of proxy listen port

* remove server map, network settings

* remove nat info usage

* nil pointer error fix,remove unused fields

* update go mod

* remove proxy functionalities

* fix errors

* rm unused field

* remove old changes

* remove peer conf struct usage

* simply nat detection,remove unused funcs

* rm unused func

* send host ack

* remove duplicate pull

* revert firewall changes

* fix linux build

* remove turn debug change

* return if remote conn fails
abhishek9686 added a commit that referenced this pull request Jul 28, 2023
@abhishek9686
NET-433: Set Routes Only For Egress Ranges with NAT enabled (#523)
1365ce2 
* NET-10: Refactor Peer update Phase-1 (#407)

* singleton peer update mq handler

* process adding and removing single peer

* avoid restarting daemon on join to network host update

* handle peer list on singleton update

* support multiple peer removal

* use map for peer data

* init peer map

* don't retrun if wg file update fails

* add debug comment

* add debug comment

* add func comments

* add comment

* rm ununsed funcs

* NET-193: Refactor Peer Updates - Firewall Manager (#418)

* singleton peer update mq handler

* process adding and removing single peer

* avoid restarting daemon on join to network host update

* handle peer list on singleton update

* support multiple peer removal

* use map for peer data

* init peer map

* don't retrun if wg file update fails

* add debug comment

* add debug comment

* add func comments

* add comment

* rm ununsed funcs

* detach firewall from proxy and peer updates

* rm unused funcs

* close firewall in daemon shutdown

* initialize firewall on start of the daemon

* rm config related to fw from proxy

* add netmaker forward rule on firewall init

* return if firewall is not initialized

* sync firewall rule on pull

* rm commented code

* update netclient dockerfile to support ip6tables

* rename pkg to firewall

* remove relay implementation from proxy

* remove relay implementation from proxy (#425)

* remove unwanted relay check

* remove relay config

* remove proxy server components

* remove proxy utilities

* rm unused proxy config

* remove multi-server support for turn

* remove NAT Auto Switch

* remove multi-server support for turn

* update go mod

* remove servers loop

* fix issues with merge conflicts

* NET-282: removed proxy-to-proxy comms, removed proxy udp server (#447)

* remove relay implementation from proxy

* remove unwanted relay check

* remove relay config

* remove proxy server components

* remove proxy utilities

* rm unused proxy config

* remove multi-server support for turn

* remove NAT Auto Switch

* remove multi-server support for turn

* update go mod

* remove servers loop

* fix issues with merge conflicts

* Net 282 proxy (#450)

* remove proxy manager

* use nat info for public IP

* remove server param

* rm ununsed proxy config

* statr proxy only if client is registered to a server

* rm unused func

* update go mod, remove usage of proxy listen port

* remove server map, network settings

* use tcp pinger to determine peer connection status and latency

* remove nat info usage

* nil pointer error fix,remove unused fields

* use icmp pinger for extclient

* NET-282: removed proxy dependency on peer updates, only use proxy for turn operations (#453)

* remove relay implementation from proxy

* remove unwanted relay check

* remove relay config

* remove proxy server components

* remove proxy utilities

* rm unused proxy config

* remove multi-server support for turn

* remove NAT Auto Switch

* remove multi-server support for turn

* update go mod

* remove servers loop

* fix issues with merge conflicts

* Net 282 proxy (#450)

* remove proxy manager

* use nat info for public IP

* remove server param

* rm ununsed proxy config

* statr proxy only if client is registered to a server

* rm unused func

* update go mod, remove usage of proxy listen port

* remove server map, network settings

* remove nat info usage

* nil pointer error fix,remove unused fields

* update go mod

* remove proxy functionalities

* fix errors

* rm unused field

* remove old changes

* remove peer conf struct usage

* simply nat detection,remove unused funcs

* rm unused func

* send host ack

* remove duplicate pull

* revert firewall changes

* fix linux build

* remove turn debug change

* return if remote conn fails

* stop setting ingress routes

* add only NAT rules for egress

* rm ununsed funcs

* refresh egress range routes

* log for refresh routes

* continue on first time setup

* remove egress map

* rm unused func

* forward rules changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkasun mattkasun mattkasun approved these changes

@theguy951357 theguy951357 theguy951357 approved these changes

@TobiaszCudnik TobiaszCudnik TobiaszCudnik approved these changes

@Aceix Aceix Awaiting requested review from Aceix

@gabrielseibel1 gabrielseibel1 Awaiting requested review from gabrielseibel1

@afeiszli afeiszli Awaiting requested review from afeiszli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhishek9686 @TobiaszCudnik @theguy951357 @mattkasun