-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NET-433: Set Routes Only For Egress Ranges with NAT enabled #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* singleton peer update mq handler * process adding and removing single peer * avoid restarting daemon on join to network host update * handle peer list on singleton update * support multiple peer removal * use map for peer data * init peer map * don't retrun if wg file update fails * add debug comment * add debug comment * add func comments * add comment * rm ununsed funcs
* singleton peer update mq handler * process adding and removing single peer * avoid restarting daemon on join to network host update * handle peer list on singleton update * support multiple peer removal * use map for peer data * init peer map * don't retrun if wg file update fails * add debug comment * add debug comment * add func comments * add comment * rm ununsed funcs * detach firewall from proxy and peer updates * rm unused funcs * close firewall in daemon shutdown * initialize firewall on start of the daemon * rm config related to fw from proxy * add netmaker forward rule on firewall init * return if firewall is not initialized * sync firewall rule on pull * rm commented code * update netclient dockerfile to support ip6tables * rename pkg to firewall
* remove relay implementation from proxy * remove unwanted relay check * remove relay config * remove proxy server components * remove proxy utilities * rm unused proxy config * remove multi-server support for turn * remove NAT Auto Switch * remove multi-server support for turn * update go mod * remove servers loop * fix issues with merge conflicts
* remove proxy manager * use nat info for public IP * remove server param
abhishek9686
requested review from
Aceix,
theguy951357,
gabrielseibel1,
afeiszli and
mattkasun
July 27, 2023 05:27
8 tasks
mattkasun
approved these changes
Jul 27, 2023
Aceix
approved these changes
Jul 28, 2023
theguy951357
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
-> Deprecated Ingress Routing rules
-> routing rules set only for egress gw with NAT enabled
Provide Issue ticket number if applicable/not in title
Provide link to Netmaker PR if required
gravitl/netmaker#2469
Provide testing steps
Checklist before requesting a review