Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-433: Set Routes Only For Egress Ranges with NAT enabled #523

Merged
merged 64 commits into from
Jul 28, 2023

Conversation

abhishek9686
Copy link
Member

@abhishek9686 abhishek9686 commented Jul 27, 2023

Describe your changes

-> Deprecated Ingress Routing rules
-> routing rules set only for egress gw with NAT enabled

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

gravitl/netmaker#2469

Provide testing steps

  • Verify ingress and egress functionality with both iptables and nftables machines

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

abhishek9686 and others added 30 commits May 23, 2023 15:07
* singleton peer update mq handler

* process adding and removing single peer

* avoid restarting daemon on join to network host update

* handle peer list on singleton update

* support multiple peer removal

* use map for peer data

* init peer map

* don't retrun if wg file update fails

* add debug comment

* add debug comment

* add func comments

* add comment

* rm ununsed funcs
* singleton peer update mq handler

* process adding and removing single peer

* avoid restarting daemon on join to network host update

* handle peer list on singleton update

* support multiple peer removal

* use map for peer data

* init peer map

* don't retrun if wg file update fails

* add debug comment

* add debug comment

* add func comments

* add comment

* rm ununsed funcs

* detach firewall from proxy and peer updates

* rm unused funcs

* close firewall in daemon shutdown

* initialize firewall on start of the daemon

* rm config related to fw from proxy

* add netmaker forward rule on firewall init

* return if firewall is not initialized

* sync firewall rule on pull

* rm commented code

* update netclient dockerfile to support ip6tables

* rename pkg to firewall
* remove relay implementation from proxy

* remove unwanted relay check

* remove relay config

* remove proxy server components

* remove proxy utilities

* rm unused proxy config

* remove multi-server support for turn

* remove NAT Auto Switch

* remove multi-server support for turn

* update go mod

* remove servers loop

* fix issues with merge conflicts
* remove proxy manager

* use nat info for public IP

* remove server param
Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and passed

@abhishek9686 abhishek9686 merged commit 1365ce2 into develop Jul 28, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants