Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access requests to audit events #9758

Merged
merged 3 commits into from
Jan 25, 2022

Conversation

espadolini
Copy link
Contributor

@espadolini espadolini commented Jan 12, 2022

Closes #9590.

@espadolini espadolini added audit-log Issues related to Teleports Audit Log access-requests labels Jan 17, 2022
@espadolini espadolini force-pushed the espadolini/usermetadata-requests branch from 78d1ffd to c1785a8 Compare January 17, 2022 18:01
@espadolini espadolini marked this pull request as ready for review January 17, 2022 18:03
@github-actions github-actions bot requested review from jakule and zmb3 January 17, 2022 18:03
@espadolini espadolini force-pushed the espadolini/usermetadata-requests branch 2 times, most recently from 3357400 to 21bab81 Compare January 20, 2022 10:52
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not change e to point to your branch as part of merging this. Wait until your PR over there is merged and then update.

api/types/events/events.proto Outdated Show resolved Hide resolved
@espadolini espadolini force-pushed the espadolini/usermetadata-requests branch 3 times, most recently from 37781e8 to 4cf5512 Compare January 24, 2022 18:00
@espadolini espadolini requested a review from zmb3 January 24, 2022 18:12

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@espadolini espadolini force-pushed the espadolini/usermetadata-requests branch from 85fb39e to d3c0b7c Compare January 25, 2022 16:27
@espadolini espadolini merged commit 2598401 into master Jan 25, 2022
@espadolini espadolini deleted the espadolini/usermetadata-requests branch January 25, 2022 16:56
espadolini added a commit that referenced this pull request Jan 27, 2022
* Refactor most uses of `UserMetadata` into a handful of functions

* Add access requests to `UserMetadata`

* Explanation for the reserved field in SessionStart
espadolini added a commit that referenced this pull request Jan 28, 2022
* Refactor most uses of `UserMetadata` into a handful of functions

* Add access requests to `UserMetadata`

* Explanation for the reserved field in SessionStart
espadolini added a commit that referenced this pull request Jan 31, 2022
* Refactor most uses of `UserMetadata` into a handful of functions

* Add access requests to `UserMetadata`

* Explanation for the reserved field in SessionStart
@webvictim webvictim mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
access-requests application-access audit-log Issues related to Teleports Audit Log database-access Database access related issues and PRs desktop-access kubernetes-access
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All user-generated events should list the access requests in use
3 participants