Skip to content

Commit

Permalink
Explanation for the reserved field in SessionStart
Browse files Browse the repository at this point in the history
  • Loading branch information
espadolini committed Jan 24, 2022
1 parent f66865f commit 4cf5512
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions api/types/events/events.proto
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@ message KubernetesPodMetadata {

// SessionStart is a session start event
message SessionStart {
reserved 11;
reserved "AccessRequests";

// Metadata is a common event metadata
Metadata Metadata = 1
[ (gogoproto.nullable) = false, (gogoproto.embed) = true, (gogoproto.jsontag) = "" ];
Expand Down Expand Up @@ -174,6 +171,11 @@ message SessionStart {

// SessionRecording is the type of session recording.
string SessionRecording = 10 [ (gogoproto.jsontag) = "session_recording,omitempty" ];

// AccessRequests used to be here, it is now part of UserMetadata
reserved "AccessRequests";
reserved 11;
// reserved jsontag "access_requests"
}

// SessionJoin emitted when another user joins a session
Expand Down

0 comments on commit 4cf5512

Please sign in to comment.