-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google.golang.org/grpc
to v1.43.0
#9656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/grpc_update
branch
2 times, most recently
from
January 7, 2022 14:08
c9d8fec
to
95f8820
Compare
Update grpc dependency to the latest version. Needed to fix the client side hang that prevents TwoClustersTunnel from running succesfully, see #9655.
rosstimothy
force-pushed
the
tross/grpc_update
branch
from
January 10, 2022 18:55
95f8820
to
c2e4f03
Compare
rosstimothy
force-pushed
the
tross/grpc_update
branch
from
January 10, 2022 19:28
1928e26
to
3a82e2d
Compare
…ure.NewCredentials()) to satisfy linter
rosstimothy
force-pushed
the
tross/grpc_update
branch
from
January 10, 2022 19:35
3a82e2d
to
f800bf8
Compare
zmb3
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to make update-vendor
when backporting.
espadolini
approved these changes
Jan 10, 2022
rosstimothy
added a commit
that referenced
this pull request
Jan 11, 2022
rosstimothy
added a commit
that referenced
this pull request
Jan 12, 2022
rosstimothy
added a commit
that referenced
this pull request
Jan 12, 2022
russjones
added a commit
that referenced
this pull request
Jan 15, 2022
TestTwoClustersTunnel has legitimately been failing for many months. However, we've been re-running integration tests until it passes. On master and branch/v8 we've fixed the issue by upgrading etcd and grpc dependency. #9656 #9607 Ideally we'd fix TestTwoClustersTunnel on branch/6.2 and branch/v7 by updating etcd and grpc, but as these branches are meant to be fairly stable at this point, and the risk of unintended consequences by updating etcd and grpc feels too high.
This was referenced Jan 15, 2022
russjones
added a commit
that referenced
this pull request
Jan 19, 2022
TestTwoClustersTunnel has legitimately been failing for many months. However, we've been re-running integration tests until it passes. On master and branch/v8 we've fixed the issue by upgrading etcd and grpc dependency. #9656 #9607 Ideally we'd fix TestTwoClustersTunnel on branch/6.2 and branch/v7 by updating etcd and grpc, but as these branches are meant to be fairly stable at this point, and the risk of unintended consequences by updating etcd and grpc feels too high.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update grpc dependency to the latest version. Needed to fix the client side hang that
prevents
TwoClustersTunnel
from running succesfully.Fixes #9655.