Upgrade from go.etcd.io/etcd v3.4.14 to go.etcd.io/etcd/{api,client}/v3 v3.5.1
#9607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
force-pushed
the
espadolini/update-etcd
branch
from
03b4664 to
c69e0c4
Compare
|
This would get significantly less noisy if we waited for #9545. |
espadolini
force-pushed
the
espadolini/update-etcd
branch
from
c69e0c4 to
99f0810
Compare
r0mant
reviewed
Jan 5, 2022
There was a problem hiding this comment.
@espadolini Does this actually upgrade version of etcd library we're using? If so, do you know what the changes are b/w the one we used before and this one? Just to make sure nothing regresses.
|
We upgrade the |
espadolini
force-pushed
the
espadolini/update-etcd
branch
from
99f0810 to
5fba389
Compare
espadolini
changed the title
go.etcd.io/etcd to go.etcd.io/etcd/{api,client}/v3go.etcd.io/etcd v3.4.14 to go.etcd.io/etcd/{api,client}/v3 v3.5.1
espadolini
force-pushed
the
espadolini/update-etcd
branch
2 times, most recently
from
951bcb6 to
dc4cfba
Compare
espadolini
force-pushed
the
espadolini/update-etcd
branch
from
dc4cfba to
f40dda4
Compare
r0mant
approved these changes
Jan 10, 2022
rosstimothy
approved these changes
Jan 10, 2022
espadolini
added a commit
that referenced
this pull request
Jan 11, 2022
* Prepare `etcdbk` to use the newer `go.etcd.io/etcd/v3` lib * `go get go.etcd.io/etcd/api/v3 go.etcd.io/etcd/client/v3` [v8] * Fix direct/indirect split in go.mod
russjones
added a commit
that referenced
this pull request
Jan 15, 2022
TestTwoClustersTunnel has legitimately been failing for many months. However, we've been re-running integration tests until it passes. On master and branch/v8 we've fixed the issue by upgrading etcd and grpc dependency. #9656 #9607 Ideally we'd fix TestTwoClustersTunnel on branch/6.2 and branch/v7 by updating etcd and grpc, but as these branches are meant to be fairly stable at this point, and the risk of unintended consequences by updating etcd and grpc feels too high.
This was referenced Jan 15, 2022
russjones
added a commit
that referenced
this pull request
Jan 19, 2022
TestTwoClustersTunnel has legitimately been failing for many months. However, we've been re-running integration tests until it passes. On master and branch/v8 we've fixed the issue by upgrading etcd and grpc dependency. #9656 #9607 Ideally we'd fix TestTwoClustersTunnel on branch/6.2 and branch/v7 by updating etcd and grpc, but as these branches are meant to be fairly stable at this point, and the risk of unintended consequences by updating etcd and grpc feels too high.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us upgrade other modules in the future, like
google.golang.org/grpc(which is probably needed for #9655) orgoogle.golang.org/api(which we'll need for #8122).Because of directory renamings to fit the go module convention, a small change in imports was required in
lib/backend/etcdbk/etcd.go.The only actual change listed in https://github.com/etcd-io/etcd/blob/main/CHANGELOG-3.5.md#breaking-changes relates to (*v3rpc.ClusterServer).MemberList() which we don't use, the rest is all renaming to fit in the go module convention. No changes to the client library seem to have happened between v3.4.14 and v3.4.19 (the latest 3.4 at the time of writing).
Other libraries are only bumped by minor or patch versions.