[v8] Escape access request and access resolution reasons in tctl (#9381) #9455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
changed the title
xacrimon
approved these changes
Dec 17, 2021
russjones
approved these changes
Dec 20, 2021
espadolini
force-pushed
the
espadolini/v8-tctl-escape-request-reason
branch
from
6775033 to
bcf10d2
Compare
espadolini
force-pushed
the
espadolini/v8-tctl-escape-request-reason
branch
from
bcf10d2 to
04fb457
Compare
* Pass request and resolve reasons in tctl through %q like it's done in tsh * Update tool/tctl/common/access_request_command.go Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]>
espadolini
force-pushed
the
espadolini/v8-tctl-escape-request-reason
branch
from
04fb457 to
1c6a650
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean backport of #9381, no changes.
As request and resolution reasons can contain newlines, control characters and ANSI escape codes, we pass them through fmt.Printf("%q") like it's done in tsh.
This fixes TEL-Q321-5.