Escape access request and access resolution reasons in tctl #9381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadolini
force-pushed
the
espadolini/tctl-escape-request-reason
branch
from
21ec21c to
a74df57
Compare
atburke
approved these changes
Dec 15, 2021
espadolini
force-pushed
the
espadolini/tctl-escape-request-reason
branch
from
7800fb5 to
47bb43d
Compare
fspmarshall
approved these changes
Dec 16, 2021
Co-authored-by: Andrew Burke <[email protected]>
espadolini
force-pushed
the
espadolini/tctl-escape-request-reason
branch
from
47bb43d to
6b8941e
Compare
espadolini
added a commit
that referenced
this pull request
Dec 16, 2021
* Pass request and resolve reasons in tctl through %q like it's done in tsh * Update tool/tctl/common/access_request_command.go Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]>
espadolini
added a commit
that referenced
this pull request
Dec 16, 2021
* Pass request and resolve reasons in tctl through %q like it's done in tsh * Update tool/tctl/common/access_request_command.go Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]>
espadolini
added a commit
that referenced
this pull request
Dec 16, 2021
* Pass request and resolve reasons in tctl through %q like it's done in tsh * Update tool/tctl/common/access_request_command.go Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]>
espadolini
added a commit
that referenced
this pull request
Dec 17, 2021
…9457) * Pass request and resolve reasons in tctl through %q like it's done in tsh * Update tool/tctl/common/access_request_command.go Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]>
espadolini
added a commit
that referenced
this pull request
Dec 20, 2021
* Pass request and resolve reasons in tctl through %q like it's done in tsh * Update tool/tctl/common/access_request_command.go Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]>
espadolini
added a commit
that referenced
this pull request
Dec 20, 2021
…9456) * Pass request and resolve reasons in tctl through %q like it's done in tsh * Update tool/tctl/common/access_request_command.go Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]>
espadolini
added a commit
that referenced
this pull request
Dec 20, 2021
* Pass request and resolve reasons in tctl through %q like it's done in tsh * Update tool/tctl/common/access_request_command.go Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]>
espadolini
added a commit
that referenced
this pull request
Dec 21, 2021
* Pass request and resolve reasons in tctl through %q like it's done in tsh * Update tool/tctl/common/access_request_command.go Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]>
espadolini
added a commit
that referenced
this pull request
Dec 21, 2021
…9455) * Pass request and resolve reasons in tctl through %q like it's done in tsh * Update tool/tctl/common/access_request_command.go Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]> Co-authored-by: Andrew Burke <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As request and resolution reasons can contain newlines, control characters and ANSI escape codes, we pass them through
fmt.Printf("%q")like it's done intsh.This fixes TEL-Q321-5.