Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8 backport] Update Docker image tags in docs #9402

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Dec 14, 2021

backports: #9400

Some docs pages related to our Docker images use the
(= version =) variable to populate image tags. However, this
variable uses a different format for version numbers than our
image repositories, meaning that users attempting
to pull images mentioned in these docs see an error message.

This change uses the teleport.latest_(oss|ent)_docker_image
variable instead.

Closes #7871

@github-actions github-actions bot requested a review from klizhentas December 14, 2021 20:09
@ptgott ptgott force-pushed the paul.gottschling/v8-img-update branch from b624519 to 7a6bc43 Compare December 15, 2021 19:30
@ptgott ptgott force-pushed the paul.gottschling/v8-img-update branch from 7a6bc43 to aefc6d5 Compare December 20, 2021 17:06
@ptgott ptgott force-pushed the paul.gottschling/v8-img-update branch from aefc6d5 to fd9093a Compare January 4, 2022 21:53
@ptgott ptgott force-pushed the paul.gottschling/v8-img-update branch from fd9093a to 914765e Compare January 18, 2022 20:09
@ptgott ptgott requested a review from xinding33 January 18, 2022 21:14
@ptgott ptgott force-pushed the paul.gottschling/v8-img-update branch 3 times, most recently from 74bc241 to 2daf5b4 Compare January 24, 2022 18:05
Copy link
Contributor

@xinding33 xinding33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ptgott ptgott enabled auto-merge (squash) February 2, 2022 16:17
@ptgott ptgott force-pushed the paul.gottschling/v8-img-update branch 2 times, most recently from 0d9795e to 1e80402 Compare February 4, 2022 19:21
Some docs pages related to our Docker images use the
(= version =) variable to populate image tags. However, this
variable uses a different format for version numbers than our
image repositories, meaning that users attempting
to pull images mentioned in these docs see an error message.

This change uses the teleport.latest_(oss|ent)_docker_image
variable instead.

Closes #7871
@ptgott ptgott force-pushed the paul.gottschling/v8-img-update branch from 1e80402 to 2cf18b4 Compare February 9, 2022 20:13
@ptgott ptgott merged commit 22f660c into branch/v8 Feb 9, 2022
@ptgott ptgott deleted the paul.gottschling/v8-img-update branch February 9, 2022 20:18
@webvictim webvictim mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants