Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker image tags in docs #9400

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Dec 14, 2021

Some docs pages related to our Docker images use the
(= version =) variable to populate image tags. However, this
variable uses a different format for version numbers than our
image repositories, meaning that users attempting
to pull images mentioned in these docs see an error message.

This change uses the teleport.latest_(oss|ent)_docker_image
variable instead.

Closes #7871

@github-actions github-actions bot requested a review from klizhentas December 14, 2021 20:06
@ptgott ptgott force-pushed the paul.gottschling/master-img-update branch 2 times, most recently from 275e87f to 0ee71a9 Compare December 20, 2021 17:02
@ptgott ptgott force-pushed the paul.gottschling/master-img-update branch from 0ee71a9 to 1f2eecd Compare January 4, 2022 21:54
@ptgott ptgott force-pushed the paul.gottschling/master-img-update branch from 1f2eecd to 6e8fd17 Compare January 18, 2022 20:10
@ptgott ptgott requested a review from xinding33 January 18, 2022 21:15
@ptgott ptgott force-pushed the paul.gottschling/master-img-update branch 3 times, most recently from d493c23 to 7bc442f Compare January 24, 2022 18:06
Copy link
Contributor

@xinding33 xinding33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptgott these changes look good to me. Have you tested the new docker pull command? If not, it'd be great to test that before merging.

@ptgott ptgott force-pushed the paul.gottschling/master-img-update branch from 7bc442f to 05fc6ef Compare February 3, 2022 21:54
@ptgott
Copy link
Contributor Author

ptgott commented Feb 3, 2022

@xinding33 Thanks for the review! I have tested the command.

@ptgott ptgott force-pushed the paul.gottschling/master-img-update branch from 05fc6ef to 1052747 Compare February 4, 2022 19:20
@ptgott ptgott force-pushed the paul.gottschling/master-img-update branch from 1052747 to 2ca8c67 Compare February 4, 2022 22:29
Some docs pages related to our Docker images use the
(= version =) variable to populate image tags. However, this
variable uses a different format for version numbers than our
image repositories, meaning that users attempting
to pull images mentioned in these docs see an error message.

This change uses the teleport.latest_(oss|ent)_docker_image
variable instead.

Closes #7871
@ptgott ptgott force-pushed the paul.gottschling/master-img-update branch from 2ca8c67 to bab02b7 Compare February 4, 2022 22:29
@ptgott ptgott merged commit 056ee39 into master Feb 4, 2022
@ptgott ptgott deleted the paul.gottschling/master-img-update branch February 4, 2022 22:35
ptgott added a commit that referenced this pull request Feb 4, 2022
Backports #9400

Some docs pages related to our Docker images use the
(= version =) variable to populate image tags. However, this
variable uses a different format for version numbers than our
image repositories, meaning that users attempting
to pull images mentioned in these docs see an error message.

This change uses the teleport.latest_(oss|ent)_docker_image
variable instead.
ptgott added a commit that referenced this pull request Feb 4, 2022
Backports #9400

Some docs pages related to our Docker images use the
(= version =) variable to populate image tags. However, this
variable uses a different format for version numbers than our
image repositories, meaning that users attempting
to pull images mentioned in these docs see an error message.

This change uses the teleport.latest_(oss|ent)_docker_image
variable instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v.7.0] /docs/pages/getting-started.mdx
3 participants