-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker image tags in docs #9400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2021
ptgott
force-pushed
the
paul.gottschling/master-img-update
branch
2 times, most recently
from
December 20, 2021 17:02
275e87f
to
0ee71a9
Compare
ptgott
force-pushed
the
paul.gottschling/master-img-update
branch
from
January 4, 2022 21:54
0ee71a9
to
1f2eecd
Compare
ptgott
force-pushed
the
paul.gottschling/master-img-update
branch
from
January 18, 2022 20:10
1f2eecd
to
6e8fd17
Compare
ptgott
force-pushed
the
paul.gottschling/master-img-update
branch
3 times, most recently
from
January 24, 2022 18:06
d493c23
to
7bc442f
Compare
xinding33
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ptgott these changes look good to me. Have you tested the new docker pull
command? If not, it'd be great to test that before merging.
ptgott
force-pushed
the
paul.gottschling/master-img-update
branch
from
February 3, 2022 21:54
7bc442f
to
05fc6ef
Compare
@xinding33 Thanks for the review! I have tested the command. |
ptgott
force-pushed
the
paul.gottschling/master-img-update
branch
from
February 4, 2022 19:20
05fc6ef
to
1052747
Compare
zmb3
approved these changes
Feb 4, 2022
ptgott
force-pushed
the
paul.gottschling/master-img-update
branch
from
February 4, 2022 22:29
1052747
to
2ca8c67
Compare
Some docs pages related to our Docker images use the (= version =) variable to populate image tags. However, this variable uses a different format for version numbers than our image repositories, meaning that users attempting to pull images mentioned in these docs see an error message. This change uses the teleport.latest_(oss|ent)_docker_image variable instead. Closes #7871
ptgott
force-pushed
the
paul.gottschling/master-img-update
branch
from
February 4, 2022 22:29
2ca8c67
to
bab02b7
Compare
ptgott
added a commit
that referenced
this pull request
Feb 4, 2022
Backports #9400 Some docs pages related to our Docker images use the (= version =) variable to populate image tags. However, this variable uses a different format for version numbers than our image repositories, meaning that users attempting to pull images mentioned in these docs see an error message. This change uses the teleport.latest_(oss|ent)_docker_image variable instead.
ptgott
added a commit
that referenced
this pull request
Feb 4, 2022
Backports #9400 Some docs pages related to our Docker images use the (= version =) variable to populate image tags. However, this variable uses a different format for version numbers than our image repositories, meaning that users attempting to pull images mentioned in these docs see an error message. This change uses the teleport.latest_(oss|ent)_docker_image variable instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some docs pages related to our Docker images use the
(= version =) variable to populate image tags. However, this
variable uses a different format for version numbers than our
image repositories, meaning that users attempting
to pull images mentioned in these docs see an error message.
This change uses the teleport.latest_(oss|ent)_docker_image
variable instead.
Closes #7871