Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: Add build support to FIPS Dockerfile #7407

Merged
merged 3 commits into from
Jun 29, 2021
Merged

bpf: Add build support to FIPS Dockerfile #7407

merged 3 commits into from
Jun 29, 2021

Conversation

webvictim
Copy link
Contributor

@webvictim webvictim commented Jun 24, 2021

Some necessary packages to build BPF support into Teleport binaries are missing from the FIPS buildbox Dockerfile - this adds them. Also makes the set of packages installed into the FIPS buildbox more consistent with the regular buildbox Dockerfile.

After fixing this build failure, also discovered that regular Mac pkg builds are failing on master because #5866 enabled signing for both teleport and tsh pkgs (without the appropriate changes to Drone to unlock the signing keychain) and then this didn't get completely reverted via #6265. ce0b0e7 adds the necessary changes to sign regular teleport packages for MacOS too.

Required for https://github.com/gravitational/teleport.e/pull/279

Fixes #7076
Fixes #3437

Copy link
Contributor

@wadells wadells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test this?

build.assets/Dockerfile-fips Outdated Show resolved Hide resolved
@webvictim
Copy link
Contributor Author

Tested via tag: https://drone.teleport.dev/gravitational/teleport/337

(the CentOS 6 build is failing because of the other PR #7408 - I think I'll wait for that to merge and then rebase this to get a proper test)

@webvictim
Copy link
Contributor Author

https://drone.teleport.dev/gravitational/teleport/422 is the tag build testing this.

@webvictim webvictim enabled auto-merge (squash) June 28, 2021 14:28
Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot.

@webvictim webvictim merged commit 3a6a4d6 into master Jun 29, 2021
@webvictim webvictim deleted the gus/e-bpf branch June 29, 2021 01:08
@benarent
Copy link
Contributor

@webvictim When will these be publicly available? Will it be in backported, 6.2.x or 7.0?

@webvictim
Copy link
Contributor Author

Signed Teleport MacOS packages will be available in 7.0. We can’t backport to 6.2 as it’s not using Go 1.16.

@benarent benarent added this to the 7.0 "Stockholm" milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign all MacOS Packages We need to sign teleport-ent-x.pkg
5 participants