-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpf: Add build support to FIPS Dockerfile #7407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you test this?
Tested via tag: https://drone.teleport.dev/gravitational/teleport/337 (the CentOS 6 build is failing because of the other PR #7408 - I think I'll wait for that to merge and then rebase this to get a proper test) |
https://drone.teleport.dev/gravitational/teleport/422 is the tag build testing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bot.
@webvictim When will these be publicly available? Will it be in backported, 6.2.x or 7.0? |
Signed Teleport MacOS packages will be available in 7.0. We can’t backport to 6.2 as it’s not using Go 1.16. |
Some necessary packages to build BPF support into Teleport binaries are missing from the FIPS buildbox
Dockerfile
- this adds them. Also makes the set of packages installed into the FIPS buildbox more consistent with the regular buildbox Dockerfile.After fixing this build failure, also discovered that regular Mac pkg builds are failing on
master
because #5866 enabled signing for bothteleport
andtsh
pkgs (without the appropriate changes to Drone to unlock the signing keychain) and then this didn't get completely reverted via #6265. ce0b0e7 adds the necessary changes to sign regularteleport
packages for MacOS too.Required for https://github.com/gravitational/teleport.e/pull/279
Fixes #7076
Fixes #3437