[v14] Fix the RDP licensing flow #47544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
force-pushed
the
zmb3/v14-fix-rdp-newlicense-flow
branch
from
9a8d469 to
667af23
Compare
zmb3
changed the title
zmb3
commented
Oct 24, 2024
zmb3
force-pushed
the
zmb3/v14-fix-rdp-newlicense-flow
branch
2 times, most recently
from
591769f to
e893d5a
Compare
probakowski
approved these changes
Oct 24, 2024
espadolini
approved these changes
Oct 24, 2024
public-teleport-github-review-bot
bot
removed the request for review
from mvbrock
zmb3
force-pushed
the
zmb3/v14-fix-rdp-newlicense-flow
branch
2 times, most recently
from
2bb9ca5 to
8390449
Compare
Licenses are stored in-memory, so if the agent restarts it will be forced to go through the "new license" flow for the first session.
zmb3
force-pushed
the
zmb3/v14-fix-rdp-newlicense-flow
branch
2 times, most recently
from
d5f4966 to
a553aa0
Compare
This ensures memory doesn't grow unbounded if we end up caching a large number of licenses.
zmb3
force-pushed
the
zmb3/v14-fix-rdp-newlicense-flow
branch
from
6ded4b8 to
3c0b52a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual fixes were implemented in rdp-rs, this PR just updates the dependency and API interface to accomodate the new library version.
Changelog: Fixed an issue with the Microsoft license negotiation for RDP sessions.