Enhance MS-RDPELE support #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for additional messages that are required for the upgrade license flow. Additionally, switch from using an MD5 checksum of the hostname for the client identification to a user-provided UUID. (For Teleport, this will be the UUID of the agent running the RDP client, which ensures that each client has a stable and unique identifier.)
zmb3
force-pushed
the
zmb3/enhance-license-parsing
branch
from
8516120 to
f2bbe93
Compare
Merged
probakowski
approved these changes
Oct 15, 2024
zmb3
force-pushed
the
zmb3/enhance-license-parsing
branch
from
b87a883 to
b14690c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation of MS-RDPELE is insufficient. We'll need to add hooks for client-side license storage, but before we can do that we need to parse additional metadata from the licensing PDUs.