[v15] Fix AWS App Access creation for AWS OIDC Integration when using the account number as name #45818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the integration name is digits only, the resulting address for the application will look like this: `123456789012.proxy.example.com:443` This fails to parse with go's `url.Parse`. This PR keeps the existing logic for creating the AWS App Access but does a best effort to fix this issue by removing the `:443` from the public proxy addr. If another port is used, we would still get the error.
zmb3
approved these changes
Aug 26, 2024
atburke
approved these changes
Aug 26, 2024
public-teleport-github-review-bot
bot
removed the request for review
from timothyb89
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #44480 to branch/v15
changelog: Fixed an issue that prevented the creation of AWS App Access for an Integration that used digits only (eg, AWS Account ID).