Fix AWS App Access creation for AWS OIDC Integration when using the account number as name #44480
Conversation
marcoandredinis
force-pushed
the
marco/fix-awsappaccess_accountid_integration
branch
from
e84b538 to
7a40218
Compare
There was a problem hiding this comment.
Approving since I think this works most of the time and doesn't require other changes which is nice.
As a possible alternative, have we looked at specifying a protocol? https:////123456789012.proxy.example.com:443 or even //123456789012.proxy.example.com:443 parse just fine and will work with arbitrary proxy ports, if we can prepend some characters just before we url.Parse() the address.
(I imagine things would break if we added a protocol to the app server's URL so presumably any fix like I'm suggesting would need to happen elsewhere if it would work at all)
marcoandredinis
force-pushed
the
marco/fix-awsappaccess_accountid_integration
branch
from
7a40218 to
d95593f
Compare
|
@timothyb89 Thank you for the suggestion. I changed to use the protocol and it works. I'm just not able to do a final test because of this issue |
marcoandredinis
force-pushed
the
marco/fix-awsappaccess_accountid_integration
branch
from
d95593f to
909848f
Compare
marcoandredinis
force-pushed
the
marco/fix-awsappaccess_accountid_integration
branch
from
909848f to
b377196
Compare
marcoandredinis
changed the title
marcoandredinis
force-pushed
the
marco/fix-awsappaccess_accountid_integration
branch
from
b377196 to
5902fe6
Compare
If the integration name is digits only, the resulting address for the application will look like this: `123456789012.proxy.example.com:443` This fails to parse with go's `url.Parse`. This PR keeps the existing logic for creating the AWS App Access but does a best effort to fix this issue by removing the `:443` from the public proxy addr. If another port is used, we would still get the error.
marcoandredinis
force-pushed
the
marco/fix-awsappaccess_accountid_integration
branch
from
5902fe6 to
7996cfc
Compare
|
I've changed some things, can you please take another look @timothyb89 ? Can you also please take a look @atburke ? |
marcoandredinis
deleted the
marco/fix-awsappaccess_accountid_integration
branch
|
@marcoandredinis See the table below for backport results.
|
If the integration name is digits only, the resulting address for the application will look like this:
123456789012.proxy.example.com:443This fails to parse with go's
url.Parse.This PR keeps prepends the protocol to the URL, and that makes
url.Parsehappy.changelog: Fix an issue that prevented the creation of AWS App Access for an Integration that used digits only (eg, AWS Account ID).