Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TERM_PROGRAM and TERM_PROGRAM_VERSION env vars in Teleport Connect #45014

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Aug 2, 2024

Closes #22536

According to the table in Maximus5/ConEmu#1837 (comment), the value of TERM_PROGRAM is usually the app name, so I set it to Teleport_Connect.
TERM_PROGRAM_VERSION is the version of the app.

changelog: Teleport Connect now sets TERM_PROGRAM: Teleport_Connect and TERM_PROGRAM_VERSION: <app_version> environment variables in the integrated terminal

Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a link to that comment from ConEMU, it was very informative.

@gzdunek gzdunek added this pull request to the merge queue Aug 5, 2024
Merged via the queue into master with commit 4bc3ca6 Aug 5, 2024
40 checks passed
@gzdunek gzdunek deleted the gzdunek/set-term-program branch August 5, 2024 14:18
@public-teleport-github-review-bot

@gzdunek See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect should set TERM_PROGRAM when launching a shell session
3 participants