Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect should set TERM_PROGRAM when launching a shell session #22536

Closed
2 tasks
ravicious opened this issue Mar 2, 2023 · 1 comment · Fixed by #45014
Closed
2 tasks

Connect should set TERM_PROGRAM when launching a shell session #22536

ravicious opened this issue Mar 2, 2023 · 1 comment · Fixed by #45014
Labels
feature-request Used for new features in Teleport, improvements to current should be #enhancements teleport-connect Issues related to Teleport Connect.

Comments

@ravicious
Copy link
Member

ravicious commented Mar 2, 2023 •
edited
Loading

As reported by Gerard Pretorius on the community Slack.

What would you like Teleport to do?

Connect should set TERM_PROGRAM and TERM_PROGRAM_VERSION when launching a shell session.

What problem does this solve?

TERM_PROGRAM allows users to check if the shell session was started inside Connect and make adjustments necessary for their tools.

  • Research best practices behind setting TERM_PROGRAM and TERM_PROGRAM_VERSION.
  • Set TERM_PROGRAM and TERM_PROGRAM_VERSION when opening a shell session.
@ravicious ravicious added feature-request Used for new features in Teleport, improvements to current should be #enhancements teleport-connect Issues related to Teleport Connect. labels Mar 2, 2023
@ravicious
Copy link
Member Author

For example, in my specific scenario I cannot see my cursor in vim, probably due to a bug in Xterm.js. I could make vim use another colorscheme if Connect set its own TERM_PROGRAM.

screenshot from my vim

The cursor here is on the first character in the file but due to that bug you cannot see it.

@zmb3 zmb3 mentioned this issue Apr 30, 2024
Closed
11 tasks
@gzdunek gzdunek mentioned this issue Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Used for new features in Teleport, improvements to current should be #enhancements teleport-connect Issues related to Teleport Connect.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set TERM_PROGRAM and TERM_PROGRAM_VERSION env vars in Teleport Connect gravitational/teleport
1 participant
@ravicious