Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v15] Print accurate status in tsh login output #44144

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

rosstimothy
Copy link
Contributor

@rosstimothy rosstimothy commented Jul 12, 2024

Backport #44043 to branch/v15

changelog: Ensured that tsh login outputs accurate status information for the new session.

If tsh login was executed while the user had a valid session the
resulting status shown to the user included data from the prior
session. The root cause was the profile being passed to
printLoginInformation was the old. Any profiles retrieved prior
to calling (TeleportClient)SaveProfile should be discarded and
the profile should be retrieved again to reflect the new session.

Closes #33732.
@rosstimothy rosstimothy marked this pull request as ready for review July 12, 2024 15:20
@github-actions github-actions bot added backport size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Jul 12, 2024
@github-actions github-actions bot requested review from Tener and zmb3 July 12, 2024 15:21
@rosstimothy
Copy link
Contributor Author

Friendly ping @Tener

@rosstimothy rosstimothy added this pull request to the merge queue Jul 16, 2024
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from Tener July 16, 2024 15:20
Merged via the queue into branch/v15 with commit 19dd62c Jul 16, 2024
35 checks passed
@rosstimothy rosstimothy deleted the bot/backport-44043-branch/v15 branch July 16, 2024 15:38
@camscale camscale mentioned this pull request Jul 29, 2024
This was referenced Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants