Print accurate status in tsh login output #44043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If tsh login was executed while the user had a valid session the resulting status shown to the user included data from the prior session. The root cause was the profile being passed to printLoginInformation was the old. Any profiles retrieved prior to calling (TeleportClient)SaveProfile should be discarded and the profile should be retrieved again to reflect the new session. Closes #33732.
github-actions
bot
added
size/sm
tsh
Tener
approved these changes
Jul 11, 2024
zmb3
approved these changes
Jul 11, 2024
|
@rosstimothy See the table below for backport results.
|
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tsh login was executed while the user had a valid session the resulting status shown to the user included data from the prior session. The root cause was the profile being passed to
printLoginInformationwas old. Any profiles retrieved prior to calling(TeleportClient) SaveProfileshould be discarded and the profile should be retrieved again to reflect the new session. Other branches within the login logic were already correctly refreshing the profile.Closes #33732.
Changelog: Ensure that tsh login outputs accurate status information for the new session.