Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix External Audit Storage CTA condition #42329

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

mcbattirola
Copy link
Contributor

@mcbattirola mcbattirola commented Jun 3, 2024

featureEnabled was not properly set, so users with EAS enabled would see a locked button on the CTA, as if they didn't have access to the feature.

This didn't affect the actual button to add the integration, just the CTA.

I've also fixed the useEffect dependency array condition, as ctx.hasExternalAuditStorage was missing, and cfg.isCloud shouldn't be added since it didn't came through a prop or hook

part of #42119

@mcbattirola mcbattirola marked this pull request as ready for review June 4, 2024 12:32
Copy link

github-actions bot commented Jun 4, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@mcbattirola mcbattirola added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 labels Jun 4, 2024
@mcbattirola mcbattirola added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit 3c95df4 Jun 5, 2024
39 of 41 checks passed
@mcbattirola mcbattirola deleted the mcbattirola/fix-eas-cta branch June 5, 2024 12:40
@public-teleport-github-review-bot

@mcbattirola See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants